Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to blueprint test skeleton for all stages and do a pipeline refactor #710

Merged
merged 105 commits into from
May 11, 2022
Merged

Convert to blueprint test skeleton for all stages and do a pipeline refactor #710

merged 105 commits into from
May 11, 2022

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Apr 19, 2022 •
edited
Loading

Fixes #686
Fixes #687
Fixes #688

@daniel-cit
bootstrap go test
0c9070d
@daniel-cit
fix lint
5acc18f
@daniel-cit
add env var for missing input values
5a7f4d8
@daniel-cit
add sleep after test setup for enabling api propagation
c3adba9
@daniel-cit
increase sleep time to 3 minutes
5572084
@daniel-cit
fix test assertion
128fa63
@daniel-cit
replicate env vars form converge to verify stage.
d70dfb2
@daniel-cit
fix type.
de7a9f4
@daniel-cit
skip default verify
236892d
@daniel-cit
replicate env vars form converge to destroy stage.
abe03d3
@daniel-cit
bump CFT version and update test
47fea29
@daniel-cit
update go.mod file
488ad0f
@daniel-cit
add org test
a0158f5
@daniel-cit
add org test asserts
28fdb07
@daniel-cit
fix test
811c030
@daniel-cit
disable backend bucket
23f3a07
@daniel-cit
fix domains to allow env var name
ec2bca0
@daniel-cit
fix domains to allow value
2539a0b
@daniel-cit
add domains to allow to setup output
6c44bef
@daniel-cit
add go envs tests
604c38a
@daniel-cit
fix typo
0af27ce
@daniel-cit
add tests for network, projects and app-infra
80fc7ad
@daniel-cit
disable auto.tfvars files and set access_context_manager_policy_id
797b509
@daniel-cit
wait for four minutes for api propagation
10f5eb4
@daniel-cit
add target_name_server_addresses to setup output
79663a6
@daniel-cit
update list of terraform files to disable
93d194d
@daniel-cit
add access_context_manager_policy_id to env vars of step 4 projects
55aedcd
@daniel-cit
add export to export of previous terraform script outputs
34de162
@daniel-cit
read perimeter name from env var
1c0f891
@daniel-cit
fix helper script
6fcf50c
@bharathkkb
Copy link
Member

@daniel-cit Were you planning to add the assertions in a followup?

@daniel-cit
fix assert.Contains base list
525ceb1
@daniel-cit
add restrictedDomain verification
2f600d8
@daniel-cit
fix cidrRange for shared test
bfb9593
@daniel-cit
fix monitoring_workspace_users output for testing
528bb2c
@daniel-cit
fix cloud router region in 3-networks/shared
a3f588f
@daniel-cit
fix lint issue
3ea5fff
@daniel-cit
fix firewall tests
648754a
@daniel-cit
get the len of the allowed ports array in the network test
3a1822b
@daniel-cit
fix step 4 iam tests
58ec286
@daniel-cit
fix project iam test for base_shared_vpc_project
b46cfe0
@daniel-cit
fix param for search of vpc host project id
83a98f3
@daniel-cit
fix param for search of restricted vpc host project id
3027380
@daniel-cit
increase provider request timeout to prevente dns policy error 409:Th…
a37eac5 
…e resource 'entity.policy' named 'default-policy' already exists
@daniel-cit
increase provider request timeout to 120s prevent dns policy error 40…
8fa17f6 
…9:The resource 'entity.policy' named 'default-policy' already exists
@daniel-cit daniel-cit requested a review from bharathkkb May 9, 2022 23:54
bharathkkb
bharathkkb approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but LGTM

build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
test/integration/envs/envs_test.go Outdated Show resolved Hide resolved
2-environments/envs/development/outputs.tf Outdated Show resolved Hide resolved
test/integration/networks/networks_test.go Outdated Show resolved Hide resolved
test/integration/org/org_test.go Show resolved Hide resolved
@bharathkkb bharathkkb merged commit f2d7bc8 into terraform-google-modules:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

@bharathkkb bharathkkb Awaiting requested review from bharathkkb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert test assertions Pipeline refactor Convert to bpt skeleton for all stages
3 participants
@daniel-cit @bharathkkb @apeabody