Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial module addition and tests #2

Merged
merged 27 commits into from
Nov 19, 2019
Merged

Initial module addition and tests #2

merged 27 commits into from
Nov 19, 2019

Conversation

milesmatthias
Copy link
Contributor

No description provided.

@milesmatthias milesmatthias mentioned this pull request Oct 22, 2019
Closed
2 tasks
@milesmatthias
Copy link
Contributor Author

I may need to bump a version number here...

@aaron-lane aaron-lane self-assigned this Oct 23, 2019
@aaron-lane aaron-lane added the enhancement New feature or request label Oct 23, 2019
aaron-lane
aaron-lane suggested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @milesmatthias!

Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
build/lint.cloudbuild.yaml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@milesmatthias
Copy link
Contributor Author

milesmatthias commented Oct 28, 2019 •
edited
Loading

This is all working, except getting a strange error on destroy. Any thoughts would be appreciated @aaron-lane.

---- Begin output of terraform destroy -auto-approve -lock=true -lock-timeout=0s -input=false  -parallelism=10 -refresh=true   ----
STDOUT: module.example.module.cli.null_resource.decompress: Refreshing state... [id=3733539048353473423]
module.example.null_resource.gcloud_enable_youtube: Refreshing state... [id=198914195743583451]
module.example.module.cli.null_resource.upgrade: Refreshing state... [id=3310747582243716263]
module.example.module.cli.null_resource.additional_components[0]: Refreshing state... [id=6353155148167668298]
module.example.module.cli.null_resource.additional_components[0]: Destroying... [id=6353155148167668298]
module.example.module.cli.null_resource.decompress: Destroying... [id=3733539048353473423]
module.example.module.cli.null_resource.additional_components[0]: Destruction complete after 0s
module.example.null_resource.gcloud_enable_youtube: Destroying... [id=198914195743583451]
module.example.null_resource.gcloud_enable_youtube: Provisioning with 'local-exec'...

module.example.module.cli.null_resource.decompress: Destruction complete after 0s
module.example.module.cli.null_resource.upgrade: Destroying... [id=3310747582243716263]
module.example.module.cli.null_resource.upgrade: Destruction complete after 0s
STDERR:
Error: local-exec provisioner command must be a non-empty string


---- End output of terraform destroy -auto-approve -lock=true -lock-timeout=0s -input=false  -parallelism=10 -refresh=true   ----
Ran terraform destroy -auto-approve -lock=true -lock-timeout=0s -input=false  -parallelism=10 -refresh=true   returned 1
E, [2019-10-28T16:21:25.177414 #850] ERROR -- simple-example-default: ----------------------
E, [2019-10-28T16:21:25.177687 #850] ERROR -- simple-example-default: ------Backtrace-------
E, [2019-10-28T16:21:25.177972 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/kitchen-terraform-4.9.0/lib/kitchen/driver/terraform.rb:270:in `rescue in destroy'
E, [2019-10-28T16:21:25.178226 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/kitchen-terraform-4.9.0/lib/kitchen/driver/terraform.rb:262:in `destroy'
E, [2019-10-28T16:21:25.178543 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:484:in `public_send'
E, [2019-10-28T16:21:25.178766 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:484:in `block in perform_action'
E, [2019-10-28T16:21:25.179108 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:548:in `block in synchronize_or_call'
E, [2019-10-28T16:21:25.179413 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:546:in `synchronize'
E, [2019-10-28T16:21:25.179753 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:546:in `synchronize_or_call'
E, [2019-10-28T16:21:25.192532 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:513:in `block in action'
E, [2019-10-28T16:21:25.193498 #850] ERROR -- simple-example-default: /usr/local/lib/ruby/2.6.0/benchmark.rb:293:in `measure'
E, [2019-10-28T16:21:25.194272 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:512:in `action'
E, [2019-10-28T16:21:25.194996 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:484:in `perform_action'
E, [2019-10-28T16:21:25.195684 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:471:in `destroy_action'
E, [2019-10-28T16:21:25.196508 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:382:in `block (2 levels) in transition_to'
E, [2019-10-28T16:21:25.197324 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/lifecycle_hooks.rb:45:in `run_with_hooks'
E, [2019-10-28T16:21:25.197861 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:381:in `block in transition_to'
E, [2019-10-28T16:21:25.198540 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:380:in `each'
E, [2019-10-28T16:21:25.199185 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:380:in `transition_to'
E, [2019-10-28T16:21:25.199816 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/instance.rb:173:in `destroy'
E, [2019-10-28T16:21:25.200823 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/command.rb:197:in `public_send'
E, [2019-10-28T16:21:25.201409 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/command.rb:197:in `run_action_in_thread'
E, [2019-10-28T16:21:25.201950 #850] ERROR -- simple-example-default: /usr/local/bundle/gems/test-kitchen-1.24.0/lib/kitchen/command.rb:169:in `block (2 levels) in run_action'
E, [2019-10-28T16:21:25.202713 #850] ERROR -- simple-example-default: ----End Backtrace-----

@milesmatthias
Copy link
Contributor Author

@morgante, I believe this last commit re-organizes the command in the way you're looking for. Let me know if I'm off-base.

morgante
morgante suggested changes Oct 29, 2019
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
examples/simple_example/main.tf Outdated Show resolved Hide resolved
@morgante morgante assigned morgante and unassigned aaron-lane Oct 30, 2019
morgante
morgante reviewed Oct 30, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@milesmatthias milesmatthias mentioned this pull request Nov 8, 2019
Closed
@morgante morgante merged commit d513d11 into terraform-google-modules:master Nov 19, 2019
morgante added a commit that referenced this pull request Jul 10, 2020
@morgante
Merge pull request #2 from milesmatthias/master-initial-work
8d0a4c7 
Initial module addition and tests

Former-commit-id: d513d11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@ludoo ludoo Awaiting requested review from ludoo

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

Assignees

@milesmatthias milesmatthias

@morgante morgante

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milesmatthias @morgante @aaron-lane