-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TPG version constraints to allow 4.0 #50
Update TPG version constraints to allow 4.0 #50
Conversation
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Thanks for the PR! 🚀 |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Thank you @nlamirault for putting this together, I cannot use this module without this update. For this reason, Terraform recommends using a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @nlamirault
Could you pull in changes from #44. In particular we use examples for testing modules and we want to make sure those pass. Unfortunately GKE runners are still blocked by terraform-google-modules/terraform-google-kubernetes-engine#1129
@thetimbecker Thanks for the suggestion, however we like to keep an upper constraint to validate that the module works with the new provider versions. This helps us catch issues that may have otherwise impacted our users and work with the provider teams to fix. |
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault @bharathkkb Is there anything I can do to help move this PR along? I noticed the GKE PR mentioned has been merged. I'd like to use this for a project I'm working on, so if there's any way I can help, please let me know! |
I don't have access to failed tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nlamirault looks like some lint tests are failing. You can see the details here #50 (comment). You can also run it locally using make docker_test_lint
.
Thanks @bharathkkb . I will check that. |
No description provided.