Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TPG version constraints to allow 4.0 #50

Merged

Conversation

nlamirault
Copy link
Contributor

No description provided.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault nlamirault changed the title Provider versions contraints update TPG version constraints to allow 4.0 Jan 19, 2022
@nlamirault nlamirault changed the title update TPG version constraints to allow 4.0 Update TPG version constraints to allow 4.0 Jan 19, 2022
@comment-bot-dev
Copy link

comment-bot-dev commented Jan 19, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@thetimbecker
Copy link

Thank you @nlamirault for putting this together, I cannot use this module without this update. For this reason, Terraform recommends using a >= for shared Terraform modules.

If you are writing a shared Terraform module, constrain only the minimum required provider version using a >= constraint. This should specify the minimum version containing the features your module relies on, and thus allow a user of your module to potentially select a newer provider version if other features are needed by other parts of their overall configuration.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nlamirault
Could you pull in changes from #44. In particular we use examples for testing modules and we want to make sure those pass. Unfortunately GKE runners are still blocked by terraform-google-modules/terraform-google-kubernetes-engine#1129

@bharathkkb
Copy link
Member

@thetimbecker Thanks for the suggestion, however we like to keep an upper constraint to validate that the module works with the new provider versions. This helps us catch issues that may have otherwise impacted our users and work with the provider teams to fix.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@simpsonw
Copy link

@nlamirault @bharathkkb Is there anything I can do to help move this PR along? I noticed the GKE PR mentioned has been merged. I'd like to use this for a project I'm working on, so if there's any way I can help, please let me know!

@nlamirault
Copy link
Contributor Author

I don't have access to failed tests.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlamirault looks like some lint tests are failing. You can see the details here #50 (comment). You can also run it locally using make docker_test_lint.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@nlamirault
Copy link
Contributor Author

Thanks @bharathkkb . I will check that.

@bharathkkb bharathkkb merged commit 1aebd31 into terraform-google-modules:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants