Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module separated to submodules (Fix #4) #43

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Module separated to submodules (Fix #4) #43

merged 1 commit into from
Sep 13, 2019

Conversation

paulpalamarchuk
Copy link
Contributor

@paulpalamarchuk paulpalamarchuk commented Aug 1, 2019 •
edited
Loading

Fixes #4.

@paulpalamarchuk paulpalamarchuk force-pushed the fix#4 branch 2 times, most recently from 4558769 to 73ddf86 Compare August 1, 2019 16:16
@paulpalamarchuk
Copy link
Contributor Author

#4

@paulpalamarchuk paulpalamarchuk force-pushed the fix#4 branch 19 times, most recently from 61eb22b to 3e0bc71 Compare August 2, 2019 14:51
kopachevsky
kopachevsky reviewed Aug 2, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@paulpalamarchuk paulpalamarchuk force-pushed the fix#4 branch 4 times, most recently from 58fcb84 to 61a179d Compare August 2, 2019 21:11
ingwarr
ingwarr suggested changes Aug 6, 2019
View reviewed changes
modules/folders_iam/variables.tf Show resolved Hide resolved
modules/folders_iam/variables.tf Show resolved Hide resolved
modules/kms_crypto_keys_iam/variables.tf Show resolved Hide resolved
modules/kms_crypto_keys_iam/variables.tf Show resolved Hide resolved
modules/kms_key_rings_iam/variables.tf Show resolved Hide resolved
modules/subnets_iam/variables.tf Show resolved Hide resolved
modules/subnets_iam/variables.tf Show resolved Hide resolved
test/ci_integration.sh Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
variables.tf Show resolved Hide resolved
@ingwarr
Copy link
Contributor

ingwarr commented Aug 6, 2019

@morgante From my point of view, it needs only cosmetic changes, no complaints on functionality

paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
2d4b922 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
0ad6d02 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
33616a8 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
8e1d5d5 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
db51202 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
f3234aa 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
dd6451b 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 3, 2019
@paulpalamarchuk
Update testing to use Cloud Build
9cdf242 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
@morgante morgante mentioned this pull request Sep 4, 2019
Closed
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 4, 2019
@paulpalamarchuk
Update testing to use Cloud Build
50f2720 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 4, 2019
@paulpalamarchuk
Update testing to use Cloud Build
e7cb2f3 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 4, 2019
@paulpalamarchuk
Update testing to use Cloud Build
a7bb1d2 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 4, 2019
@paulpalamarchuk
Update testing to use Cloud Build
e12e5e2 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 5, 2019
@paulpalamarchuk
Update testing to use Cloud Build
47d358c 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 6, 2019
@paulpalamarchuk
Update testing to use Cloud Build
f315b2e 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
aaron-lane
aaron-lane suggested changes Sep 6, 2019
View reviewed changes
main.tf
@@ -15,126 +15,111 @@
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the changes to the module structure already prevent backward compatibility, I suggest that we drop the root module rather than introducing breaking changes and a large variable interface which simply proxies each submodule.

@morgante do you have any thoughts about this?

@aaron-lane aaron-lane changed the base branch from aaron-lane-0.12 to master September 13, 2019 17:47
@paulpalamarchuk @aaron-lane
Fixes terraform-google-modules#4: Allow referencing computed value
fcfd23e 
 * Changed internal processing structure of `bindings`
 * Everything moved to submodules
 * Updated variables
 * Added `*_num` variables to make counts work with computed values
 * Updated examples
 * Updatet README.md
 * Added `subnets_region` variable
 * Added tests for subnets
@aaron-lane aaron-lane merged commit 61ab72b into terraform-google-modules:master Sep 13, 2019
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 16, 2019
@paulpalamarchuk
Update testing to use Cloud Build
10082de 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 16, 2019
@paulpalamarchuk
Update testing to use Cloud Build
350fe10 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 24, 2019
@paulpalamarchuk
Update testing to use Cloud Build
bdc2216 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 24, 2019
@paulpalamarchuk
Update testing to use Cloud Build
96ab108 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 25, 2019
@paulpalamarchuk
Update testing to use Cloud Build
5f00e2e 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 25, 2019
@paulpalamarchuk
Update testing to use Cloud Build
3752301 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
paulpalamarchuk added a commit to paulpalamarchuk/terraform-google-iam that referenced this pull request Sep 25, 2019
@paulpalamarchuk
Update testing to use Cloud Build
a02d015 
 * Based on PR terraform-google-modules#43
 * Fix terraform-google-modules#49
 * README.md - some syntax errors fixed
 * Splitted lint-test (Fix terraform-google-modules#51)
 * Improved test fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick4fake nick4fake nick4fake approved these changes

@kopachevsky kopachevsky kopachevsky approved these changes

@ingwarr ingwarr ingwarr approved these changes

@aaron-lane aaron-lane aaron-lane approved these changes

Assignees

@aaron-lane aaron-lane

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: command "bash" produced invalid JSON Allow referencing computed values
5 participants
@paulpalamarchuk @ingwarr @nick4fake @kopachevsky @aaron-lane