Migrate to for_each. Get rid of *_num options (breaking change). Fix destructiveness of updates. Add new playground test suite for testing updates. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule behaves on role updates
|
Found a way to replicate this with the simplest usecase. In the base scenario of having 2 projects and 1 role specified with 1 member in authoritative mode. Adding just one additional role will lead to recreation of one iam resource instead of just reusing it. https://gist.github.com/cray0000/1f75fec0a6d32d2f31f8a4502e2558cd |
…k to 'count' when dynamic). [test/update] Change test to generate project ids statically instead of getting them from the resource outputs
cray0000
changed the title
…ariations of dynamic/static and authoritative/additive
… mode only for one entity. Support dynamic members only in authoritative mode. [test/update] Update tests to properly work the first time. Should pass on CI now.
…thoritative tests accordingly. Add ability to specify amount of roles to test in the 'update' test suite. [ci] Test how the module behaves on updates (of projects_iam module)
…-iam into f-test-updates
cray0000
changed the title
cray0000
changed the title
…[ci] Test configuration update for the whole authoritavite and additive suites. [test][update] rename update test suite to static-and-dynamic. Refactor.
aaron-lane
suggested changes
Oct 21, 2019
There was a problem hiding this comment.
Thanks @cray0000!
A few changes requested. In addition, we need an upgrade guide similar to the existing ones under docs since we are breaking the existing interface.
…adme] fix typos. [migration] Add migration guide from 3.0 to 4.0
aaron-lane
suggested changes
Oct 24, 2019
test/integration/static-and-dynamic/controls/static-and-dynamic.rb
Outdated
Show resolved
Hide resolved
…ynamic] Refactor procedural generation of tests.
aaron-lane
force-pushed
the
f-test-updates
branch
from
04d4d51 to
9f9d1ff
Compare
aaron-lane
force-pushed
the
f-test-updates
branch
from
9f9d1ff to
d4abeb2
Compare
…outputs from setup to kitchen.
|
@cray0000 Can you make sure tests pass? |
…tead of 'projects'
aaron-lane
suggested changes
Nov 5, 2019
aaron-lane
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix Adding new bindings is a destructive operation #11
fix for_each rewrite #46
fix Fix adding new bindings in additive mode #38
fix specifying a single project in projects-iam causes module to do nothing #69
Add a new test suite to use as a playground to test how the module behaves on role updates
Figure out a way to stabilize the roles/members order. This lead to breaking changes to the API. More on this below.
Migrate from
counttofor_eachfor static and dynamic usecases. Remove*_numoptionsAdd configuration update test into the CI. More on this below.
Add an upgrade guide from 3.0 to 4.0
API changes
*_numoptions are removed.projects_iam) only when 1 entity is passed. If you pass 2 or more, the configuration has to be static, meaning that it can't use any of the other resource's fields to get the entity name from (this includes getting the randomly generated hashes through therandom_idresource).authoritativemode.Testing configuration update.
In the
updatetest suite I've setup an additional variableroles(defaults to2) which you can pass asTF_VAR_roles=3when running theconvergecommand. The fixtures currently support the amount of roles from1to3. But it's trivial to add more, if needed in future.This way we can reconverge the
updatetest suite with differentTF_VAR_rolesvalues and verify. And by doing this multiple times we are basically testing the module configuration update behavior.