Added IAM member submodule #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kopachevsky
commented
Dec 27, 2019
kopachevsky
commented
- Fix module doesn't work with dynamically computed values any longer #75
kopachevsky
force-pushed
the
issues/75/member_roles
branch
from
c7b3e27 to
2c28c06
Compare
morgante
suggested changes
Dec 27, 2019
examples/member_iam/main.tf
Outdated
|
|
||
| module "member_roles" { | ||
| source = "../../modules/member_iam" | ||
| service_account_address = var.service_account_address |
There was a problem hiding this comment.
Don't make this a variable, create the service account in the example.
examples/member_iam/variables.tf
Outdated
| type = string | ||
| } | ||
|
|
||
| variable "project_roles" { |
There was a problem hiding this comment.
Don't make this a variable, just hardcode a few roles in the example.
| * limitations under the License. | ||
| */ | ||
|
|
||
| output "roles" { |
There was a problem hiding this comment.
Outputs which simply pass back inputs are not useful and considered an anti-pattern. At a minimum these outputs should be constructed from the resource outputs.
Or simply return the entire resource as an output (value = google_project_iam_member.project_iam_member).
kopachevsky
force-pushed
the
issues/75/member_roles
branch
5 times, most recently
from
ec60c2c to
f8dd047
Compare
paulpalamarchuk
previously requested changes
Dec 30, 2019
examples/member_iam/versions.tf
Outdated
| */ | ||
|
|
||
| terraform { | ||
| required_version = ">= 0.12" |
There was a problem hiding this comment.
This example wont work with TF ver < 0.12.6
examples/member_iam/main.tf
Outdated
| Provider configuration | ||
| *****************************************/ | ||
| provider "google" { | ||
| version = "~> 2.7" |
There was a problem hiding this comment.
Are you sure about the version?
kopachevsky
force-pushed
the
issues/75/member_roles
branch
from
f8dd047 to
ca90164
Compare
morgante
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.