Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for routes #14

Merged
merged 4 commits into from
Nov 13, 2018
Merged

Add support for routes #14

merged 4 commits into from
Nov 13, 2018

Conversation

andreyk-code
Copy link
Contributor

No description provided.

@morgante morgante self-requested a review October 24, 2018 00:34
morgante
morgante suggested changes Oct 24, 2018
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, just some small suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/simple_project/main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@andreyk-code
Copy link
Contributor Author

Thanks for review! Updated syntax per comments.

@andreyk-code andreyk-code merged commit 8d2d699 into terraform-google-modules:master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreyk-code @morgante