Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fabric-project submodule has complicated parent ID #258

Closed
averbuks opened this issue Aug 14, 2019 · 0 comments
Closed

fabric-project submodule has complicated parent ID #258

averbuks opened this issue Aug 14, 2019 · 0 comments
Assignees
@averbuks

Comments

@averbuks
Copy link
Member

Currently, parent is specified using both the parent_id and parent_type.
It makes it complex to combine with https://github.com/terraform-google-modules/terraform-google-folders where the output has them both separated by '/'.
It would be better to have only one var 'parent' which is a concatenation of 'parent_type'/'parent_id'
@averbuks averbuks self-assigned this Aug 14, 2019
averbuks added a commit to averbuks/terraform-google-project-factory that referenced this issue Aug 14, 2019
@averbuks
Deprecate 'parent_type' and 'parent_id' input variables by replacing …
2ccc94b 
…with parent variable terraform-google-modules#258
@averbuks averbuks mentioned this issue Aug 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@averbuks averbuks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@averbuks