Concourse CI #91
Merged
Concourse CI #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per conversation with @adrienthebo, he's going to take on the changes to fixtures necessary to get |
|
We may need to revert #92, as I tested it without doing a clean build from scratch. I'm getting the following when running Error: Error running plan: 7 error(s) occurred:
* module.project-factory.google_project_iam_member.gke_host_agent: google_project_iam_member.gke_host_agent: value of 'count' cannot be computed
* module.project-factory.google_compute_shared_vpc_service_project.shared_vpc_attachment: google_compute_shared_vpc_service_project.shared_vpc_attachment: value of 'count' cannot be computed
* module.project-factory.google_compute_subnetwork_iam_member.gke_shared_vpc_subnets: google_compute_subnetwork_iam_member.gke_shared_vpc_subnets: value of 'count' cannot be computed
* module.project-factory.google_project_iam_member.controlling_group_vpc_membership: google_project_iam_member.controlling_group_vpc_membership: value of 'count' cannot be computed
* module.project-factory.google_compute_subnetwork_iam_member.group_role_to_vpc_subnets: google_compute_subnetwork_iam_member.group_role_to_vpc_subnets: value of 'count' cannot be computed
* module.project-factory.google_compute_subnetwork_iam_member.apis_service_account_role_to_vpc_subnets: google_compute_subnetwork_iam_member.apis_service_account_role_to_vpc_subnets: value of 'count' cannot be computed
* module.project-factory.google_compute_subnetwork_iam_member.service_account_role_to_vpc_subnets: google_compute_subnetwork_iam_member.service_account_role_to_vpc_subnets: value of 'count' cannot be computedThis throws a pretty big gear in the works of creating self contained tests since this may require two Terraform runs to complete. @Jberlinsky you ran into this issue with the GKE module, right? |
adrienthebo
force-pushed
the
feature/ci
branch
from
aec0757 to
31019d9
Compare
|
Rewound this PR to 31019d9 to remove the shared VPC host project creation. |
Jberlinsky
force-pushed
the
feature/ci
branch
2 times, most recently
from
d369977 to
7639fde
Compare
adrienthebo
force-pushed
the
feature/ci
branch
from
64e9600 to
49f2c5e
Compare
Jberlinsky
force-pushed
the
feature/ci
branch
from
7a761f4 to
8e8e256
Compare
morgante
suggested changes
Jan 10, 2019
aaron-lane
suggested changes
Jan 10, 2019
morgante
reviewed
Jan 10, 2019
aaron-lane
approved these changes
Jan 11, 2019
This reverts commit 4859cb0.
We're seeing some odd interactions when tearing down projects that have the `compute` and the `container` APIs enabled that is causing project teardown to fail. This commit removes the explicit addition of the compute API since the container API will implicitly enable it.
This reverts commit 49f2c5e.
This works around precondition failures around disabling project services with dependencies.
Jberlinsky
force-pushed
the
feature/ci
branch
from
ed84bd6 to
be7aa85
Compare
Co-Authored-By: Jberlinsky <jberlinsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares the repository to be run in Concourse: