Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support simple sa creation without any project level roles #149

Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat: support simple sa creation without any project level roles #149

merged 1 commit into from
Jan 24, 2025
+6 −5

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Jan 23, 2025

No description provided.

@q2w q2w marked this pull request as ready for review January 23, 2025 20:55
@q2w q2w requested a review from a team as a code owner January 23, 2025 20:55
apeabody
apeabody approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @q2w!

@q2w q2w merged commit ba869e7 into terraform-google-modules:main Jan 24, 2025
4 checks passed
@release-please release-please bot mentioned this pull request Jan 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q2w @apeabody