feat: Add ip_address to bgp_peer_options in vpn_ha

[tnk-ysk]

Summary

Add ip_address field to bgp_peer_options to allow users to specify the ip_address of the google_compute_router_peer`.

References

• https://registry.terraform.io/providers/hashicorp/google/4.62.0/docs/resources/compute_router_peer#argument-reference

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun

[imrannayer]

/gcbrun

[ivayloivanov388]

Please make this an optional variable. If you use the latest module without optional variable, then the module errors if you don't have it in your confirm
..........>
│ 39: backup-vpn = {
│ 40: bgp_peer = {
│ 41: address = var.backup_bgp_remote_ip
│ 42: asn = var.bgp_peer_asn
│ 43: }
│ 44: bgp_peer_options = {
│ 45: advertise_groups = null
│ 46: advertise_ip_ranges = var.advertised_routes
│ 47: advertise_mode = "CUSTOM"
│ 48: route_priority = 100
│ 49: }

...........

│ The given value is not suitable for module.vpn_ha_wa2.module.vpn_ha_wa2.var.tunnels declared at
│ .terraform/modules/vpn_ha_wa2.vpn_ha_wa2/modules/vpn_ha/variables.tf:90,1-19: element "main-vpn": attribute "bgp_peer_options":
│ attribute "ip_address" is required.

[tnk-ysk]

Optional attributes were added in terraform 1.3.0.
https://github.com/hashicorp/terraform/blob/v1.3/CHANGELOG.md#130-september-21-2022

but this module is meant for use with Terraform 0.12, That's why I didn't use optional.

terraform-google-vpn/README.md

Line 15 in bdc0963

This module is meant for use with Terraform 0.12. If you haven't [upgraded](https://www.terraform.io/upgrade-guides/0-12.html)

[imrannayer]

This module has optional attribute for some time. We need to update version information to reflect it and also make attributes optional if they are optional. Will create a separate Issue and PR.

Thanks

[imrannayer]

Please make this an optional variable. If you use the latest module without optional variable, then the module errors if you don't have it in your confirm ..........> │ 39: backup-vpn = { │ 40: bgp_peer = { │ 41: address = var.backup_bgp_remote_ip │ 42: asn = var.bgp_peer_asn │ 43: } │ 44: bgp_peer_options = { │ 45: advertise_groups = null │ 46: advertise_ip_ranges = var.advertised_routes │ 47: advertise_mode = "CUSTOM" │ 48: route_priority = 100 │ 49: }

...........

│ The given value is not suitable for module.vpn_ha_wa2.module.vpn_ha_wa2.var.tunnels declared at │ .terraform/modules/vpn_ha_wa2.vpn_ha_wa2/modules/vpn_ha/variables.tf:90,1-19: element "main-vpn": attribute "bgp_peer_options": │ attribute "ip_address" is required.

Can you set ip_address = null for the time being?