plugin2host: Send marked values over the wire #239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #235
For similar reasons as #235, values marked sensitive were not sent to plugins. In particular, there is a technical difficulty that marked values cannot simply be serialized.
https://github.com/terraform-linters/tflint/blob/v0.45.0/plugin/server.go#L128-L137
https://github.com/zclconf/go-cty/blob/v1.13.0/cty/msgpack/marshal.go#L46-L48
https://github.com/zclconf/go-cty/blob/v1.13.0/docs/marks.md#marks-under-serialization
This PR serializes sensitive values in a proprietary way so that they can be sent to plugins. Below are compatibility notes:
cty.DynamicPseudoType
it now returns the marked value instead of an error.Be aware that the TFLint v0.46 + SDK v0.15 can unintentionally expose sensitive values to plugins. To avoid this, the server should return sensitive values only for SDK 0.16+.