Skip to content

rules missing from documentation #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PatMyron opened this issue Dec 23, 2021 · 0 comments · Fixed by #286
Closed

rules missing from documentation #229

PatMyron opened this issue Dec 23, 2021 · 0 comments · Fixed by #286

Comments

@PatMyron
Copy link
Contributor

PatMyron commented Dec 23, 2021 •
edited
Loading

https://github.com/terraform-linters/tflint-ruleset-aws/tree/master/docs/rules

aws_dynamodb_table_invalid_stream_view_type
aws_iam_group_policy_too_long
aws_iam_policy_sid_invalid_characters
aws_iam_policy_too_long_policy
aws_lambda_function_deprecated_runtime
aws_mq_broker_invalid_engine_type
aws_mq_configuration_invalid_engine_type
aws_s3_bucket_invalid_acl
aws_s3_bucket_invalid_region
aws_spot_fleet_request_invalid_excess_capacity_termination_policy

6/10 look converted from SDK-based validations: terraform-linters/tflint#728 (comment), think @Rihoj wrote the others

Could probably add an automatic check to enforce presence of rules in https://github.com/terraform-linters/tflint-ruleset-aws/blob/master/docs/rules/README.md.tmpl after adding those
@PatMyron PatMyron mentioned this issue Dec 24, 2021
Merged
wata727 pushed a commit that referenced this issue Dec 24, 2021
@PatMyron
docs: documenting undocumented rules (#231)
3f84a48 
* docs: documenting undocumented rules

#229

* go generate

* fix: best practice markdown column

* go generate
Rihoj added a commit to Rihoj/tflint-ruleset-aws that referenced this issue Jan 1, 2022
@Rihoj
Updated missing documentation to fix terraform-linters#229
3a99b87
@Rihoj Rihoj mentioned this issue Jan 1, 2022
Merged
wata727 added a commit that referenced this issue Jan 8, 2022
@Rihoj @wata727
Updated missing documentation (#286)
56c58dd 
* Updated missing documentation to fix #229

* Update docs/rules/README.md.tmpl

Fix spelling of disallow

Co-authored-by: Kazuma Watanabe <watassbass@gmail.com>

* Update docs/rules/README.md.tmpl

Fix double space issue

Co-authored-by: Kazuma Watanabe <watassbass@gmail.com>

* Created the readme

Run the go generate command to generate the readme.

Co-authored-by: Kazuma Watanabe <watassbass@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated missing documentation Rihoj/tflint-ruleset-aws
1 participant
@PatMyron