-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapping aws_acmpca_certificate and aws_acmpca_certificate_authority_certificate #218
Conversation
…ertificate https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acmpca_certificate https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acmpca_certificate_authority_certificate https://github.com/aws/aws-sdk-go/blob/main/models/apis/acm-pca/2017-08-22/api-2.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@wata727 when trying to generate rules, thoughts on catching Similar to what we did here and I think it worked well: |
Sounds good! |
prev: terraform-linters/tflint#274, terraform-linters/tflint#421
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acmpca_certificate
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acmpca_certificate_authority_certificate
https://github.com/aws/aws-sdk-go/blob/main/models/apis/acm-pca/2017-08-22/api-2.json
struggled to run
go generate ./...
until realizing I was missing the git submodule:tflint-ruleset-aws/.github/workflows/generated_code_checks.yml
Line 29 in 66c25cd
https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules
services with issues (invalid repeat count, invalid character class, unsupported lookahead syntax):
#228, #232, #242, #252, #238, #263, #268
also need to bump Terraform provider schema to map new resource types: #259