Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapping aws_acmpca_certificate and aws_acmpca_certificate_authority_certificate #218

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Dec 21, 2021

prev: terraform-linters/tflint#274, terraform-linters/tflint#421


https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acmpca_certificate
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/acmpca_certificate_authority_certificate
https://github.com/aws/aws-sdk-go/blob/main/models/apis/acm-pca/2017-08-22/api-2.json


struggled to run go generate ./... until realizing I was missing the git submodule:

run: go generate ./... && git diff --exit-code

panic: open aws-sdk-go/models/apis/acm-pca/2017-08-22/api-2.json: no such file or directory

https://stackoverflow.com/questions/3796927/how-to-git-clone-including-submodules


services with issues (invalid repeat count, invalid character class, unsupported lookahead syntax):
#228, #232, #242, #252, #238, #263, #268


also need to bump Terraform provider schema to map new resource types: #259

@PatMyron PatMyron marked this pull request as draft December 21, 2021 21:41
@PatMyron PatMyron marked this pull request as ready for review December 21, 2021 23:08
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PatMyron
Copy link
Contributor Author

PatMyron commented Jan 7, 2022

services with regular expression pattern issues (invalid repeat count, invalid character class, unsupported lookahead syntax):
#228, #232, #242, #252, #238, #263, #268

@wata727 when trying to generate rules, thoughts on catching error parsing regexp panics with logging / warnings and just automatically skipping to the next rule? Might speed up mapping if those can be ignored rather than needing to be removed

Similar to what we did here and I think it worked well:
aws-cloudformation/cfn-lint#1867 (comment)

@wata727
Copy link
Member

wata727 commented Jan 8, 2022

Sounds good!

@PatMyron PatMyron mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants