Accept 8.0 as a correct version on MySQL server
#179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatMyron
reviewed
Jun 19, 2022
Comment on lines
25
to
28
| enum: []string{ | ||
| "5.7", | ||
| "8.0.21", | ||
| "8.0", | ||
| }, |
There was a problem hiding this comment.
think we should consider dropping rules when automation breaks rather than switching them to be manually maintained since these enums will become outdated:
https://sourcegraph.com/search?q=context:global+r:terraform-linters/tflint-ruleset-+enum:+[]+-file:/models/|/apispec/
There was a problem hiding this comment.
You are right, but ideally, this enum should be maintained by users of this ruleset, like #171. I find automation useful to help you notice problems more quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171