Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unused_required_providers: implement autofix #103

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

unused_required_providers: implement autofix #103

wants to merge 2 commits into from

Conversation

bendrucker
Copy link
Member

Implements autofix for terraform_unused_required_providers, on top of #93

@bendrucker bendrucker requested a review from wata727 June 13, 2023 00:49
Base automatically changed from autofix to main June 13, 2023 14:00
wata727
wata727 reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

But the reason I didn't include this autofix in #93 is because of #21.
I'm concerned that the autofix will make this issue worse. What do you think?

@bendrucker
Copy link
Member Author

Hmm, I don't know that it necessarily makes #21 much worse. People who have hit that either disabled the rule or added tflint-ignore comments. It could be slightly more confusing, i.e. auto fix might make you more liable to think TFLint is right and your code is wrong.

@wata727
Copy link
Member

wata727 commented Jun 15, 2023 •
edited
Loading

auto fix might make you more liable to think TFLint is right and your code is wrong.

Yes, I'm concerned about this possibility.

But for those who haven't faced this issue, autofix is obviously useful.
So I approve of this change. I respect your decision to merge or not.

If you do merge, please rebase against the main branch as the base branch has been updated.

wata727
wata727 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wata727 wata727 wata727 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bendrucker @wata727