Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Gateway Load Balancer Support #975

Closed
bflad opened this issue Nov 19, 2020 · 1 comment · Fixed by #976
Closed

AWS Gateway Load Balancer Support #975

bflad opened this issue Nov 19, 2020 · 1 comment · Fixed by #976

Comments

@bflad
Copy link

bflad commented Nov 19, 2020

Version

0.20.3

Description

AWS recently announced support for a new type of Elastic Load Balancing solution, Gateway Load Balancers. Upstream support for this was released in AWS Go SDK version 1.35.25 and Terraform AWS Provider version 3.15.0.

The following two rules are now out of date for this support:

2 issue(s) found:

Error: "gateway" is an invalid value as load_balancer_type (aws_lb_invalid_load_balancer_type)

  on /tmp/tmp.dlbkTdYWjQ/main.tf line 2:
   2:   load_balancer_type = "gateway"

Error: "GENEVE" is an invalid value as protocol (aws_lb_target_group_invalid_protocol)

  on /tmp/tmp.dlbkTdYWjQ/main.tf line 13:
  13:   protocol = "GENEVE"

References
bflad added a commit to hashicorp/terraform-provider-aws that referenced this issue Nov 19, 2020
@bflad
tests/provider: Ignore out of date tflint rules aws_lb_invalid_load_b…
e122cad 
…alancer_type and aws_lb_target_group_invalid_protocol

Reference: terraform-linters/tflint#975
@bendrucker bendrucker mentioned this issue Nov 19, 2020
Merged
@bendrucker
Copy link
Member

bendrucker commented Nov 19, 2020 •
edited
Loading

Thanks Brian! #976 will fix this.

bflad added a commit to hashicorp/terraform-provider-aws that referenced this issue Nov 25, 2020
@bflad
resource/aws_lb_listener: Mark port argument as optional and only def…
48be9c6 
…ault protocol argument to HTTP for Application Load Balancers (Support Gateway Load Balancer) (#16306)

* resource/aws_lb_listener: Mark port argument as optional and only default protocol argument to HTTP for Application Load Balancers (Support Gateway Load Balancer)

Reference: #16228

Output from acceptance testing:

```
--- PASS: TestAccAWSLBListener_BackwardsCompatibility (164.54s)
--- PASS: TestAccAWSLBListener_basic (216.95s)
--- PASS: TestAccAWSLBListener_basicUdp (353.16s)
--- PASS: TestAccAWSLBListener_cognito (175.47s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order (179.98s)
--- PASS: TestAccAWSLBListener_DefaultAction_Order_Recreates (210.11s)
--- PASS: TestAccAWSLBListener_fixedResponse (205.74s)
--- PASS: TestAccAWSLBListener_forwardWeighted (254.29s)
--- PASS: TestAccAWSLBListener_https (177.85s)
--- PASS: TestAccAWSLBListener_LoadBalancerArn_GatewayLoadBalancer (104.60s)
--- PASS: TestAccAWSLBListener_oidc (224.41s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (338.84s)
--- PASS: TestAccAWSLBListener_redirect (215.20s)

--- PASS: TestAccAWSLBListenerRule_Action_Order (173.51s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (190.92s)
--- PASS: TestAccAWSLBListenerRule_BackwardsCompatibility (215.63s)
--- PASS: TestAccAWSLBListenerRule_basic (205.27s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (241.13s)
--- PASS: TestAccAWSLBListenerRule_cognito (204.34s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (14.00s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (213.13s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (258.35s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (0.56s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (180.34s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (193.68s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (205.29s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (245.64s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (203.60s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (239.41s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (174.24s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (244.72s)
--- PASS: TestAccAWSLBListenerRule_forwardWeighted (298.68s)
--- PASS: TestAccAWSLBListenerRule_oidc (226.14s)
--- PASS: TestAccAWSLBListenerRule_priority (352.95s)
--- PASS: TestAccAWSLBListenerRule_redirect (162.81s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (233.36s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (204.08s)
```

* tests/provider: Ignore out of date tflint rules  aws_lb_invalid_load_balancer_type and aws_lb_target_group_invalid_protocol

Reference: terraform-linters/tflint#975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update aws-sdk, generate rules terraform-linters/tflint
2 participants
@bflad @bendrucker