install: handle GitHub API JSON without newlines #2176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles GitHub API responses that do not include newlines. Previously, if the
releases/latest
response lacked newlines within its JSON,get_latest_release
would returnmentions_count
since that is the last double-quoted string on the line grep matched (the whole object).Now,
sed
will only capture the string value after"tag_name"
. It looks past a colon and optional surrounding whitespace and captures the next double quoted group. This is compatible with both compact and multiline JSON.We still need
grep
to handle multiline JSON, since we need to exclude all lines other than the one we want. Otherwise the output is the original object with a single malformed line containing the latest version. GNUsed
can handle multiline input with-z
so keepinggrep
for that preserves portability.Closes #2175