-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tag Support to API Gateway REST API Resource #10581
Add Tag Support to API Gateway REST API Resource #10581
Conversation
merge changes
pull changes
merge changes
This reverts commit 60418c6
add tag support for api_gateway_rest_api resource expose arn attribute add arn match test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking nit, otherwise looks good, @DrFaust92 🚀
Output from acceptance testing:
--- PASS: TestAccAWSAPIGatewayRestApi_openapi (35.26s)
--- PASS: TestAccAWSAPIGatewayRestApi_tags (66.82s)
--- PASS: TestAccAWSAPIGatewayRestApi_api_key_source (67.18s)
--- PASS: TestAccAWSAPIGatewayRestApi_policy (124.97s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration_Private (171.00s)
--- PASS: TestAccAWSAPIGatewayRestApi_EndpointConfiguration (270.16s)
--- PASS: TestAccAWSAPIGatewayRestApi_disappears (389.77s)
--- PASS: TestAccAWSAPIGatewayRestApi_basic (438.28s)
@@ -221,14 +235,14 @@ func resourceAwsApiGatewayRestApiRead(d *schema.ResourceData, meta interface{}) | |||
|
|||
d.Set("binary_media_types", api.BinaryMediaTypes) | |||
|
|||
arn := arn.ARN{ | |||
execution_arn := arn.ARN{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Standard Go language conventions are to use lowercase mixed caps for variable naming.
This has been released in version 2.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #8744
Release note for CHANGELOG:
Output from acceptance testing: