data source for a step function state machine

[AndyMoore]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

New Data Source: aws_sfn_state_machine

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSfnStateMachine'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSfnStateMachine -timeout 120m
=== RUN   TestAccDataSourceAwsSfnStateMachine
=== PAUSE TestAccDataSourceAwsSfnStateMachine
=== CONT  TestAccDataSourceAwsSfnStateMachine
--- PASS: TestAccDataSourceAwsSfnStateMachine (32.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.094s

...

This is a data source for a SFN state machine. Only question is whether the additional attributes are needed beyond name/arn..

[bflad]

Hi @AndyMoore 👋 Thank you for submitting this. Overall its looking pretty good, just some minor things and this should be good to go. Please reach out with any questions or if you do not have time to implement the feedback.

[AndyMoore]

thanks for reviewing, think I got everything. still passing tests:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSfnStateMachine -timeout 120m
=== RUN   TestAccDataSourceAwsSfnStateMachine
=== PAUSE TestAccDataSourceAwsSfnStateMachine
=== CONT  TestAccDataSourceAwsSfnStateMachine
--- PASS: TestAccDataSourceAwsSfnStateMachine (35.97s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.023s

[bflad]

Looking really good, @AndyMoore, two small updates and this should be good to go. Thanks!

[AndyMoore]

thanks - both fixed. tests still pass:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSfnStateMachine'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsSfnStateMachine -timeout 120m
=== RUN   TestAccDataSourceAwsSfnStateMachine
=== PAUSE TestAccDataSourceAwsSfnStateMachine
=== CONT  TestAccDataSourceAwsSfnStateMachine
--- PASS: TestAccDataSourceAwsSfnStateMachine (35.29s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       35.348s

[bflad]

Fantastic, thanks @AndyMoore 🚀

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsSfnStateMachine (10.91s)

[ghost]

This has been released in version 2.51.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!