Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_job: Add tags argument and arn attribute #10968

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 21, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #7668

Release note for CHANGELOG:

* resource/aws_glue_job: Add `tags` argument and `arn` attribute

Output from acceptance testing:

--- PASS: TestAccAWSGlueJob_AllocatedCapacity (34.80s)
--- PASS: TestAccAWSGlueJob_Basic (27.40s)
--- PASS: TestAccAWSGlueJob_Command (35.99s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.55s)
--- PASS: TestAccAWSGlueJob_Description (35.79s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (32.81s)
--- PASS: TestAccAWSGlueJob_GlueVersion (30.32s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (34.52s)
--- PASS: TestAccAWSGlueJob_MaxRetries (30.56s)
--- PASS: TestAccAWSGlueJob_PythonShell (56.96s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (39.82s)
--- PASS: TestAccAWSGlueJob_Tags (132.80s)
--- PASS: TestAccAWSGlueJob_Timeout (31.40s)
--- PASS: TestAccAWSGlueJob_WorkerType (57.93s)

Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (34.80s)
--- PASS: TestAccAWSGlueJob_Basic (27.40s)
--- PASS: TestAccAWSGlueJob_Command (35.99s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.55s)
--- PASS: TestAccAWSGlueJob_Description (35.79s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (32.81s)
--- PASS: TestAccAWSGlueJob_GlueVersion (30.32s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (34.52s)
--- PASS: TestAccAWSGlueJob_MaxRetries (30.56s)
--- PASS: TestAccAWSGlueJob_PythonShell (56.96s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (39.82s)
--- PASS: TestAccAWSGlueJob_Tags (132.80s)
--- PASS: TestAccAWSGlueJob_Timeout (31.40s)
--- PASS: TestAccAWSGlueJob_WorkerType (57.93s)
```
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 21, 2019
@bflad bflad requested a review from a team November 21, 2019 13:08
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Nov 21, 2019
@ryndaniels ryndaniels self-assigned this Nov 21, 2019
@ryndaniels ryndaniels removed the needs-triage Waiting for first response or review from a maintainer. label Nov 21, 2019
Copy link
Contributor

@ryndaniels ryndaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

--- PASS: TestAccAWSGlueJob_Basic (29.88s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (48.03s)
--- PASS: TestAccAWSGlueJob_Description (52.73s)
--- PASS: TestAccAWSGlueJob_GlueVersion (65.31s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (68.38s)
--- PASS: TestAccAWSGlueJob_Tags (75.68s)
--- PASS: TestAccAWSGlueJob_Timeout (79.81s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (82.66s)
--- PASS: TestAccAWSGlueJob_WorkerType (86.32s)
--- PASS: TestAccAWSGlueJob_MaxRetries (113.15s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (115.25s)
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (116.48s)
--- PASS: TestAccAWSGlueJob_Command (119.99s)
--- PASS: TestAccAWSGlueJob_PythonShell (140.75s)

@bflad bflad added this to the v2.39.0 milestone Nov 21, 2019
@bflad bflad merged commit e8d4204 into master Nov 21, 2019
@bflad bflad deleted the f-aws_glue_job-tags branch November 21, 2019 13:54
bflad added a commit that referenced this pull request Nov 21, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

pixelpogo pushed a commit to babbel/terraform-provider-aws that referenced this pull request Nov 22, 2019
…#10968)

Reference: hashicorp#7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (34.80s)
--- PASS: TestAccAWSGlueJob_Basic (27.40s)
--- PASS: TestAccAWSGlueJob_Command (35.99s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.55s)
--- PASS: TestAccAWSGlueJob_Description (35.79s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (32.81s)
--- PASS: TestAccAWSGlueJob_GlueVersion (30.32s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (34.52s)
--- PASS: TestAccAWSGlueJob_MaxRetries (30.56s)
--- PASS: TestAccAWSGlueJob_PythonShell (56.96s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (39.82s)
--- PASS: TestAccAWSGlueJob_Tags (132.80s)
--- PASS: TestAccAWSGlueJob_Timeout (31.40s)
--- PASS: TestAccAWSGlueJob_WorkerType (57.93s)
```
pixelpogo pushed a commit to babbel/terraform-provider-aws that referenced this pull request Nov 22, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost unassigned ryndaniels Mar 29, 2020
@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants