Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Glue resources: Add support for resource tags #7668

Closed
3 of 4 tasks
ewbankkit opened this issue Feb 23, 2019 · 7 comments
Closed
3 of 4 tasks

AWS Glue resources: Add support for resource tags #7668

ewbankkit opened this issue Feb 23, 2019 · 7 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service.
Milestone
v2.39.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Feb 23, 2019 •
edited by bflad
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Support for tagging AWS Glue resources added in AWS SDK v1.17.4:

AWS Glue adds support for assigning AWS resource tags to jobs, triggers, development endpoints, and crawlers. Each tag consists of a key and an optional value, both of which you define. With this capacity, customers can use tags in AWS Glue to easily organize and identify your resources, create cost allocation reports, and control access to resources.

Affected resources:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 23, 2019
@ewbankkit ewbankkit mentioned this issue Feb 24, 2019
Merged
@ewbankkit
Copy link
Contributor Author

Announcement:

@bflad bflad added good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service. labels Apr 11, 2019
@ewbankkit ewbankkit mentioned this issue Apr 25, 2019
Closed
@shrimats
Copy link

What is the status of this ticket? Is someone working on this - tagging glue resources (supported by AWS since Feb)

@yozamacs
Copy link

I would like to work on it if no one else has started (and it seems like no one has...)

yozamacs added a commit to yozamacs/terraform-provider-aws that referenced this issue Aug 23, 2019
@yozamacs
Issue hashicorp#7668 - Add tags for AWS glue resources
ee91eb3
@yozamacs
Copy link

Hi! If someone could take a look at what I started on this issue in #9866 I would really appreciate it!

@bflad bflad mentioned this issue Oct 30, 2019
Closed
@bflad bflad added this to the v2.36.0 milestone Nov 8, 2019
bflad added a commit that referenced this issue Nov 8, 2019
@bflad
resource/aws_glue_crawler: Add tags argument
557eed9 
Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (28.38s)
=== CONT  TestAccAWSGlueCrawler_Description
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (40.11s)
--- PASS: TestAccAWSGlueCrawler_recreates (43.78s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (50.51s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (65.68s)
--- PASS: TestAccAWSGlueCrawler_Schedule (66.49s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (71.86s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (79.39s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (80.65s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (82.52s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (83.61s)
--- PASS: TestAccAWSGlueCrawler_Description (57.27s)
--- PASS: TestAccAWSGlueCrawler_Configuration (87.52s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (92.15s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (95.38s)
--- PASS: TestAccAWSGlueCrawler_S3Target (100.83s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (101.16s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (103.88s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (103.90s)
--- PASS: TestAccAWSGlueCrawler_Tags (120.73s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (124.13s)
```
@bflad bflad mentioned this issue Nov 8, 2019
Merged
@bflad bflad modified the milestones: v2.36.0, v2.37.0 Nov 14, 2019
bflad added a commit that referenced this issue Nov 15, 2019
@bflad
resource/aws_glue_crawler: Add tags argument (#10805)
1ca7ef8 
Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueCrawler_Role_ARN_NoPath (28.38s)
=== CONT  TestAccAWSGlueCrawler_Description
--- PASS: TestAccAWSGlueCrawler_DynamodbTarget (40.11s)
--- PASS: TestAccAWSGlueCrawler_recreates (43.78s)
--- PASS: TestAccAWSGlueCrawler_SchemaChangePolicy (50.51s)
--- PASS: TestAccAWSGlueCrawler_Role_Name_Path (65.68s)
--- PASS: TestAccAWSGlueCrawler_Schedule (66.49s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget (71.86s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Multiple (79.39s)
--- PASS: TestAccAWSGlueCrawler_Classifiers (80.65s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget (82.52s)
--- PASS: TestAccAWSGlueCrawler_TablePrefix (83.61s)
--- PASS: TestAccAWSGlueCrawler_Description (57.27s)
--- PASS: TestAccAWSGlueCrawler_Configuration (87.52s)
--- PASS: TestAccAWSGlueCrawler_Role_ARN_Path (92.15s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Multiple (95.38s)
--- PASS: TestAccAWSGlueCrawler_S3Target (100.83s)
--- PASS: TestAccAWSGlueCrawler_JdbcTarget_Exclusions (101.16s)
--- PASS: TestAccAWSGlueCrawler_CatalogTarget_Multiple (103.88s)
--- PASS: TestAccAWSGlueCrawler_S3Target_Exclusions (103.90s)
--- PASS: TestAccAWSGlueCrawler_Tags (120.73s)
--- PASS: TestAccAWSGlueCrawler_SecurityConfiguration (124.13s)
```
@bflad bflad modified the milestones: v2.37.0, v2.39.0 Nov 18, 2019
bflad added a commit that referenced this issue Nov 21, 2019
@bflad
resource/aws_glue_trigger: Add tags argument and arn attribute
d2e3053 
Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueTrigger_Basic (24.18s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (25.65s)
--- PASS: TestAccAWSGlueTrigger_Description (38.32s)
--- PASS: TestAccAWSGlueTrigger_Predicate (74.17s)
--- PASS: TestAccAWSGlueTrigger_Tags (75.60s)
--- PASS: TestAccAWSGlueTrigger_Schedule (77.46s)
--- PASS: TestAccAWSGlueTrigger_Enabled (88.06s)
--- PASS: TestAccAWSGlueTrigger_Crawler (128.09s)
```
@bflad bflad mentioned this issue Nov 21, 2019
Merged
bflad added a commit that referenced this issue Nov 21, 2019
@bflad
resource/aws_glue_job: Add tags argument and arn attribute
bcca863 
Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (34.80s)
--- PASS: TestAccAWSGlueJob_Basic (27.40s)
--- PASS: TestAccAWSGlueJob_Command (35.99s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.55s)
--- PASS: TestAccAWSGlueJob_Description (35.79s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (32.81s)
--- PASS: TestAccAWSGlueJob_GlueVersion (30.32s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (34.52s)
--- PASS: TestAccAWSGlueJob_MaxRetries (30.56s)
--- PASS: TestAccAWSGlueJob_PythonShell (56.96s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (39.82s)
--- PASS: TestAccAWSGlueJob_Tags (132.80s)
--- PASS: TestAccAWSGlueJob_Timeout (31.40s)
--- PASS: TestAccAWSGlueJob_WorkerType (57.93s)
```
@bflad bflad mentioned this issue Nov 21, 2019
Merged
bflad added a commit that referenced this issue Nov 21, 2019
@bflad
resource/aws_glue_job: Add tags argument and arn attribute (#10968)
e8d4204 
Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (34.80s)
--- PASS: TestAccAWSGlueJob_Basic (27.40s)
--- PASS: TestAccAWSGlueJob_Command (35.99s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.55s)
--- PASS: TestAccAWSGlueJob_Description (35.79s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (32.81s)
--- PASS: TestAccAWSGlueJob_GlueVersion (30.32s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (34.52s)
--- PASS: TestAccAWSGlueJob_MaxRetries (30.56s)
--- PASS: TestAccAWSGlueJob_PythonShell (56.96s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (39.82s)
--- PASS: TestAccAWSGlueJob_Tags (132.80s)
--- PASS: TestAccAWSGlueJob_Timeout (31.40s)
--- PASS: TestAccAWSGlueJob_WorkerType (57.93s)
```
bflad added a commit that referenced this issue Nov 21, 2019
@bflad
resource/aws_glue_trigger: Add tags argument and arn attribute (#10967)
eedb60a 
Reference: #7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueTrigger_Basic (24.18s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (25.65s)
--- PASS: TestAccAWSGlueTrigger_Description (38.32s)
--- PASS: TestAccAWSGlueTrigger_Predicate (74.17s)
--- PASS: TestAccAWSGlueTrigger_Tags (75.60s)
--- PASS: TestAccAWSGlueTrigger_Schedule (77.46s)
--- PASS: TestAccAWSGlueTrigger_Enabled (88.06s)
--- PASS: TestAccAWSGlueTrigger_Crawler (128.09s)
```
@bflad
Copy link
Contributor

bflad commented Nov 21, 2019

Hi folks 👋 Tagging support has been added to released Terraform resources, including aws_glue_job and aws_glue_trigger, which will release later today with version 2.39.0 of the Terraform AWS Provider. For additional feature requests or bug reports with Glue tagging functionality (e.g. tagging support in the unreleased aws_glue_dev_endpoint resource), please create new GitHub issues. Thanks. 👍

@bflad bflad closed this as completed Nov 21, 2019
@ghost
Copy link

ghost commented Nov 21, 2019

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

pixelpogo pushed a commit to babbel/terraform-provider-aws that referenced this issue Nov 22, 2019
@bflad @pixelpogo
resource/aws_glue_job: Add tags argument and arn attribute (hashicorp…
41d2442 
…#10968)

Reference: hashicorp#7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueJob_AllocatedCapacity (34.80s)
--- PASS: TestAccAWSGlueJob_Basic (27.40s)
--- PASS: TestAccAWSGlueJob_Command (35.99s)
--- PASS: TestAccAWSGlueJob_DefaultArguments (39.55s)
--- PASS: TestAccAWSGlueJob_Description (35.79s)
--- PASS: TestAccAWSGlueJob_ExecutionProperty (32.81s)
--- PASS: TestAccAWSGlueJob_GlueVersion (30.32s)
--- PASS: TestAccAWSGlueJob_MaxCapacity (34.52s)
--- PASS: TestAccAWSGlueJob_MaxRetries (30.56s)
--- PASS: TestAccAWSGlueJob_PythonShell (56.96s)
--- PASS: TestAccAWSGlueJob_SecurityConfiguration (39.82s)
--- PASS: TestAccAWSGlueJob_Tags (132.80s)
--- PASS: TestAccAWSGlueJob_Timeout (31.40s)
--- PASS: TestAccAWSGlueJob_WorkerType (57.93s)
```
pixelpogo pushed a commit to babbel/terraform-provider-aws that referenced this issue Nov 22, 2019
@bflad @pixelpogo
resource/aws_glue_trigger: Add tags argument and arn attribute (hashi…
b669673 
…corp#10967)

Reference: hashicorp#7668

Output from acceptance testing:

```
--- PASS: TestAccAWSGlueTrigger_Basic (24.18s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (25.65s)
--- PASS: TestAccAWSGlueTrigger_Description (38.32s)
--- PASS: TestAccAWSGlueTrigger_Predicate (74.17s)
--- PASS: TestAccAWSGlueTrigger_Tags (75.60s)
--- PASS: TestAccAWSGlueTrigger_Schedule (77.46s)
--- PASS: TestAccAWSGlueTrigger_Enabled (88.06s)
--- PASS: TestAccAWSGlueTrigger_Crawler (128.09s)
```
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/glue Issues and PRs that pertain to the glue service.
Projects
None yet
Milestone
v2.39.0
Development

No branches or pull requests
4 participants
@bflad @shrimats @ewbankkit @yozamacs