New resource aws_glue_dev_endpoint #7895

jckuester · 2019-03-12T08:56:33Z

Changes proposed in this pull request:

Add support for new resource aws_glue_dev_endpoint

Output from acceptance testing:

--- PASS: TestAccGlueDevEndpoint_ExtraPythonLibsS3Path (506.02s)
--- PASS: TestAccGlueDevEndpoint_Basic (532.90s)
--- PASS: TestAccGlueDevEndpoint_SecurityConfiguration (546.74s)
--- PASS: TestAccGlueDevEndpoint_NumberOfWorkers (556.80s)
--- PASS: TestAccGlueDevEndpoint_Arguments (590.41s)
--- PASS: TestAccGlueDevEndpoint_Tags (598.73s)
--- PASS: TestAccGlueDevEndpoint_PublicKey (608.57s)
--- PASS: TestAccGlueDevEndpoint_PublicKeys (797.27s)
--- PASS: TestAccGlueDevEndpoint_ExtraJarsS3Path (853.46s)
--- PASS: TestAccGlueDevEndpoint_GlueVersion (948.85s)
--- PASS: TestAccGlueDevEndpoint_NumberOfNodes (972.99s)
--- PASS: TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs (1194.39s)
--- PASS: TestAccGlueDevEndpoint_WorkerType (1444.21s)
--- PASS: TestAccGlueDevEndpoint_disappears (472.50s)
...

xmj · 2019-04-09T09:10:27Z

@jckuester wondering if you could rebase this and fix the merge conflict

maartenpeters · 2019-05-21T07:29:41Z

Is there any indication as to when this feature will be merged?

kabeersvohra · 2019-07-15T14:38:16Z

Can this be reviewed? Thanks

RobinDong · 2019-09-13T06:34:10Z

When will this patch be released to new version of terraform?

aeschright · 2019-10-02T20:51:59Z

Hi folks! The AWS Provider team is still working on catching up to a substantial PR backlog. You can see more about the process here: https://github.com/terraform-providers/terraform-provider-aws/wiki/Frequently-Asked-Questions#when-will-this-pull-request-be-merged

We'll have an update on the PR as soon as we can. Thanks for the work you've done so far.

jckuester · 2020-01-03T16:29:15Z

I updated this PR to support the newest API changes from AWS (i.e., I added support for the glue_version, worker_type, etc. arguments). Tests are all passing.

jckuester · 2020-11-08T20:07:45Z

@DrFaust92 I am done addressing feedback from the 2nd round.

DrFaust92

LGTM

--- PASS: TestAccGlueDevEndpoint_disappears (503.34s)--- PASS: TestAccGlueDevEndpoint_ExtraPythonLibsS3Path (517.23s)
--- PASS: TestAccGlueDevEndpoint_Tags (591.90s)
--- PASS: TestAccGlueDevEndpoint_ExtraJarsS3Path (596.16s)
--- PASS: TestAccGlueDevEndpoint_Arguments (603.62s)
--- PASS: TestAccGlueDevEndpoint_SecurityConfiguration (649.98s)
--- PASS: TestAccGlueDevEndpoint_Basic (660.52s)
--- PASS: TestAccGlueDevEndpoint_PublicKeys (666.27s)
--- PASS: TestAccGlueDevEndpoint_PublicKey (710.84s)
--- PASS: TestAccGlueDevEndpoint_NumberOfNodes (1028.32s)
--- PASS: TestAccGlueDevEndpoint_GlueVersion (1033.62s)
--- PASS: TestAccGlueDevEndpoint_NumberOfWorkers (1109.88s)
--- PASS: TestAccGlueDevEndpoint_WorkerType (1119.71s)
--- PASS: TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs (1201.81s)

Add glue_version, worker_type, etc. arguments

Remove for in for loop

jckuester · 2020-11-09T19:35:20Z

I had to rebase one more time, because the changes I made to fix the linter issue in /aws/resource_aws_kinesis_firehose_delivery_stream_test.go has been merged to master and caused a merge conflict.

breathingdust · 2020-11-12T23:42:07Z

LGTM 🚀 Thanks @jckuester for the implementation

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccGlueDevEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccGlueDevEndpoint_ -timeout 120m
=== RUN   TestAccGlueDevEndpoint_Basic
=== PAUSE TestAccGlueDevEndpoint_Basic
=== RUN   TestAccGlueDevEndpoint_Arguments
=== PAUSE TestAccGlueDevEndpoint_Arguments
=== RUN   TestAccGlueDevEndpoint_ExtraJarsS3Path
=== PAUSE TestAccGlueDevEndpoint_ExtraJarsS3Path
=== RUN   TestAccGlueDevEndpoint_ExtraPythonLibsS3Path
=== PAUSE TestAccGlueDevEndpoint_ExtraPythonLibsS3Path
=== RUN   TestAccGlueDevEndpoint_GlueVersion
=== PAUSE TestAccGlueDevEndpoint_GlueVersion
=== RUN   TestAccGlueDevEndpoint_NumberOfNodes
=== PAUSE TestAccGlueDevEndpoint_NumberOfNodes
=== RUN   TestAccGlueDevEndpoint_NumberOfWorkers
=== PAUSE TestAccGlueDevEndpoint_NumberOfWorkers
=== RUN   TestAccGlueDevEndpoint_PublicKey
=== PAUSE TestAccGlueDevEndpoint_PublicKey
=== RUN   TestAccGlueDevEndpoint_PublicKeys
=== PAUSE TestAccGlueDevEndpoint_PublicKeys
=== RUN   TestAccGlueDevEndpoint_SecurityConfiguration
=== PAUSE TestAccGlueDevEndpoint_SecurityConfiguration
=== RUN   TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
=== PAUSE TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
=== RUN   TestAccGlueDevEndpoint_Tags
=== PAUSE TestAccGlueDevEndpoint_Tags
=== RUN   TestAccGlueDevEndpoint_WorkerType
=== PAUSE TestAccGlueDevEndpoint_WorkerType
=== RUN   TestAccGlueDevEndpoint_disappears
=== PAUSE TestAccGlueDevEndpoint_disappears
=== CONT  TestAccGlueDevEndpoint_Basic
=== CONT  TestAccGlueDevEndpoint_PublicKeys
=== CONT  TestAccGlueDevEndpoint_WorkerType
=== CONT  TestAccGlueDevEndpoint_ExtraPythonLibsS3Path
=== CONT  TestAccGlueDevEndpoint_Tags
=== CONT  TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
=== CONT  TestAccGlueDevEndpoint_SecurityConfiguration
=== CONT  TestAccGlueDevEndpoint_GlueVersion
=== CONT  TestAccGlueDevEndpoint_PublicKey
=== CONT  TestAccGlueDevEndpoint_NumberOfWorkers
=== CONT  TestAccGlueDevEndpoint_NumberOfNodes
=== CONT  TestAccGlueDevEndpoint_disappears
=== CONT  TestAccGlueDevEndpoint_ExtraJarsS3Path
=== CONT  TestAccGlueDevEndpoint_Arguments
--- PASS: TestAccGlueDevEndpoint_SecurityConfiguration (512.71s)
--- PASS: TestAccGlueDevEndpoint_ExtraJarsS3Path (520.95s)
--- PASS: TestAccGlueDevEndpoint_disappears (528.26s)
--- PASS: TestAccGlueDevEndpoint_PublicKey (541.51s)
--- PASS: TestAccGlueDevEndpoint_ExtraPythonLibsS3Path (572.25s)
--- PASS: TestAccGlueDevEndpoint_PublicKeys (588.59s)
--- PASS: TestAccGlueDevEndpoint_Basic (648.55s)
--- PASS: TestAccGlueDevEndpoint_Tags (680.84s)
--- PASS: TestAccGlueDevEndpoint_Arguments (694.13s)
--- PASS: TestAccGlueDevEndpoint_GlueVersion (908.04s)
--- PASS: TestAccGlueDevEndpoint_NumberOfNodes (937.37s)
--- PASS: TestAccGlueDevEndpoint_NumberOfWorkers (958.03s)
--- PASS: TestAccGlueDevEndpoint_WorkerType (1167.59s)
--- PASS: TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs (1192.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1198.043s

GovCloud however has a consistent test failure (us-gov-west-1), #16170 tracks this issue for internal resolution.

make testacc TEST=./aws/ TESTARGS='-run=TestAccGlueDevEndpoint_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccGlueDevEndpoint_ -timeout 120m
=== RUN   TestAccGlueDevEndpoint_Basic
=== PAUSE TestAccGlueDevEndpoint_Basic
=== RUN   TestAccGlueDevEndpoint_Arguments
=== PAUSE TestAccGlueDevEndpoint_Arguments
=== RUN   TestAccGlueDevEndpoint_ExtraJarsS3Path
=== PAUSE TestAccGlueDevEndpoint_ExtraJarsS3Path
=== RUN   TestAccGlueDevEndpoint_ExtraPythonLibsS3Path
=== PAUSE TestAccGlueDevEndpoint_ExtraPythonLibsS3Path
=== RUN   TestAccGlueDevEndpoint_GlueVersion
=== PAUSE TestAccGlueDevEndpoint_GlueVersion
=== RUN   TestAccGlueDevEndpoint_NumberOfNodes
=== PAUSE TestAccGlueDevEndpoint_NumberOfNodes
=== RUN   TestAccGlueDevEndpoint_NumberOfWorkers
=== PAUSE TestAccGlueDevEndpoint_NumberOfWorkers
=== RUN   TestAccGlueDevEndpoint_PublicKey
=== PAUSE TestAccGlueDevEndpoint_PublicKey
=== RUN   TestAccGlueDevEndpoint_PublicKeys
=== PAUSE TestAccGlueDevEndpoint_PublicKeys
=== RUN   TestAccGlueDevEndpoint_SecurityConfiguration
=== PAUSE TestAccGlueDevEndpoint_SecurityConfiguration
=== RUN   TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
=== PAUSE TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
=== RUN   TestAccGlueDevEndpoint_Tags
=== PAUSE TestAccGlueDevEndpoint_Tags
=== RUN   TestAccGlueDevEndpoint_WorkerType
=== PAUSE TestAccGlueDevEndpoint_WorkerType
=== RUN   TestAccGlueDevEndpoint_disappears
=== PAUSE TestAccGlueDevEndpoint_disappears
=== CONT  TestAccGlueDevEndpoint_Basic
=== CONT  TestAccGlueDevEndpoint_PublicKeys
=== CONT  TestAccGlueDevEndpoint_WorkerType
=== CONT  TestAccGlueDevEndpoint_SecurityConfiguration
=== CONT  TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
=== CONT  TestAccGlueDevEndpoint_GlueVersion
=== CONT  TestAccGlueDevEndpoint_PublicKey
=== CONT  TestAccGlueDevEndpoint_NumberOfWorkers
=== CONT  TestAccGlueDevEndpoint_Tags
=== CONT  TestAccGlueDevEndpoint_NumberOfNodes
=== CONT  TestAccGlueDevEndpoint_ExtraJarsS3Path
=== CONT  TestAccGlueDevEndpoint_ExtraPythonLibsS3Path
=== CONT  TestAccGlueDevEndpoint_disappears
=== CONT  TestAccGlueDevEndpoint_Arguments
2020/11/12 13:48:58 [WARN] Truncating attribute path of 0 diagnostics for TypeSet
2020/11/12 13:49:00 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
2020/11/12 13:49:00 [DEBUG] Trying to get account information via sts:GetCallerIdentity
=== CONT  TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs
    resource_aws_glue_dev_endpoint_test.go:447: Step 1/2 error: Error running apply: 2020/11/12 13:49:01 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0

        Error: error while waiting for Glue Dev Endpoint (tf-acc-test-831422846705845092) to become available: unexpected state 'FAILED', wanted target 'READY'. last error: %!s(<nil>)


--- PASS: TestAccGlueDevEndpoint_PublicKeys (429.68s)
--- PASS: TestAccGlueDevEndpoint_disappears (430.88s)
2020/11/12 13:56:10 [INFO] AWS Auth provider used: "SharedCredentialsProvider"
--- PASS: TestAccGlueDevEndpoint_SecurityConfiguration (469.67s)
--- PASS: TestAccGlueDevEndpoint_Basic (477.31s)
--- PASS: TestAccGlueDevEndpoint_ExtraPythonLibsS3Path (481.32s)
--- PASS: TestAccGlueDevEndpoint_PublicKey (513.28s)
--- PASS: TestAccGlueDevEndpoint_Tags (546.82s)
--- PASS: TestAccGlueDevEndpoint_ExtraJarsS3Path (549.80s)
--- PASS: TestAccGlueDevEndpoint_Arguments (620.08s)
--- FAIL: TestAccGlueDevEndpoint_SubnetID_SecurityGroupIDs (690.11s)
--- PASS: TestAccGlueDevEndpoint_NumberOfNodes (776.66s)
--- PASS: TestAccGlueDevEndpoint_WorkerType (843.22s)
--- PASS: TestAccGlueDevEndpoint_GlueVersion (909.22s)
--- PASS: TestAccGlueDevEndpoint_NumberOfWorkers (1138.67s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	1140.605s
FAIL
make: *** [testacc] Error 1

ghost · 2020-11-18T19:54:33Z

This has been released in version 3.16.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-12-13T17:10:07Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch from 525ca50 to 71045a2 Compare March 12, 2019 08:58

jckuester mentioned this pull request Mar 12, 2019

Feature Request: Resource for managing AWS Glue Developer Endpoints #3876

Closed

bflad added new-resource Introduces a new resource. and removed service/codebuild Issues and PRs that pertain to the codebuild service. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Mar 12, 2019

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch from 71045a2 to ca0158c Compare April 10, 2019 18:52

aeschright requested a review from a team June 26, 2019 00:52

ewbankkit mentioned this pull request Nov 8, 2019

AWS Glue resources: Add support for resource tags #7668

Closed

4 tasks

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch 4 times, most recently from 44cc9fd to 844b950 Compare December 22, 2019 12:19

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch from 844b950 to e00a093 Compare January 3, 2020 14:30

jckuester closed this Jan 3, 2020

jckuester deleted the feature/resource-aws-glue-dev-endpoint branch January 3, 2020 15:15

jckuester reopened this Jan 3, 2020

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch from e00a093 to d10b891 Compare January 3, 2020 16:26

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch 2 times, most recently from 10bc53e to e02d1e7 Compare November 8, 2020 19:52

ghost added the service/firehose Issues and PRs that pertain to the firehose service. label Nov 8, 2020

DrFaust92 self-assigned this Nov 8, 2020

DrFaust92 approved these changes Nov 8, 2020

View reviewed changes

jckuester added 12 commits November 9, 2020 20:32

Add resource aws_glue_dev_endpoint

a235907

Update Glue Dev Endpoint to AWS API changes

2ef0259

Add glue_version, worker_type, etc. arguments

Switch to Terraform Plugin SDK Version 2

7b03448

Switch to Terraform 0.12 Syntax

b3371a2

Please the linters

0ee148f

Address comments

adce4a1

Clean up TestAccGlueDevEndpoint_Arguments

88d3b45

Fix and simplify diffArguments func

86bc3cc

Remove for in for loop

Add TestAccGlueDevEndpoint_disappears

3bde600

Address comments of 2nd feedback round

0eee437

Fix more comments

404f176

Fix tests after feedback

153d787

DrFaust92 removed the service/firehose Issues and PRs that pertain to the firehose service. label Nov 9, 2020

jckuester force-pushed the feature/resource-aws-glue-dev-endpoint branch from 4df3cd3 to 153d787 Compare November 9, 2020 19:33

breathingdust mentioned this pull request Nov 12, 2020

tests/provider: Glue Dev Endpoint Test Fail (GovCloud) #16170

Closed

breathingdust added this to the v3.16.0 milestone Nov 12, 2020

breathingdust merged commit d344d08 into hashicorp:master Nov 12, 2020

breathingdust added a commit that referenced this pull request Nov 12, 2020

Update CHANGELOG.md for #7895

9bee80b

ghost locked as resolved and limited conversation to collaborators Dec 13, 2020

DrFaust92 removed their assignment Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource aws_glue_dev_endpoint #7895

New resource aws_glue_dev_endpoint #7895

jckuester commented Mar 12, 2019 •

edited

Loading

xmj commented Apr 9, 2019

maartenpeters commented May 21, 2019

kabeersvohra commented Jul 15, 2019

RobinDong commented Sep 13, 2019

aeschright commented Oct 2, 2019

jckuester commented Jan 3, 2020 •

edited

Loading

jckuester commented Nov 8, 2020

DrFaust92 left a comment

jckuester commented Nov 9, 2020 •

edited

Loading

breathingdust commented Nov 12, 2020

ghost commented Nov 18, 2020

ghost commented Dec 13, 2020

New resource aws_glue_dev_endpoint #7895

New resource aws_glue_dev_endpoint #7895

Conversation

jckuester commented Mar 12, 2019 • edited Loading

xmj commented Apr 9, 2019

maartenpeters commented May 21, 2019

kabeersvohra commented Jul 15, 2019

RobinDong commented Sep 13, 2019

aeschright commented Oct 2, 2019

jckuester commented Jan 3, 2020 • edited Loading

jckuester commented Nov 8, 2020

DrFaust92 left a comment

Choose a reason for hiding this comment

jckuester commented Nov 9, 2020 • edited Loading

breathingdust commented Nov 12, 2020

ghost commented Nov 18, 2020

ghost commented Dec 13, 2020

jckuester commented Mar 12, 2019 •

edited

Loading

jckuester commented Jan 3, 2020 •

edited

Loading

jckuester commented Nov 9, 2020 •

edited

Loading