resource/aws_lambda_function: Support waiting for State on CreateFunction and LastUpdatedStatus on UpdateFunctionConfiguration

[bflad]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

* resource/aws_lambda_function: Support waiting for function creation and configuration updates

Output from acceptance testing:

--- PASS: TestAccAWSLambdaFunction_basic (70.19s)
--- PASS: TestAccAWSLambdaFunction_concurrency (211.45s)
--- PASS: TestAccAWSLambdaFunction_concurrencyCycle (534.73s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfig (521.90s)
--- PASS: TestAccAWSLambdaFunction_DeadLetterConfigUpdated (523.26s)
--- PASS: TestAccAWSLambdaFunction_EmptyVpcConfig (123.36s)
--- PASS: TestAccAWSLambdaFunction_encryptedEnvVariables (532.25s)
--- PASS: TestAccAWSLambdaFunction_envVariables (577.05s)
--- PASS: TestAccAWSLambdaFunction_expectFilenameAndS3Attributes (22.88s)
--- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (524.97s)
--- PASS: TestAccAWSLambdaFunction_Layers (389.18s)
--- PASS: TestAccAWSLambdaFunction_LayersUpdate (162.39s)
--- PASS: TestAccAWSLambdaFunction_localUpdate (579.02s)
--- PASS: TestAccAWSLambdaFunction_localUpdate_nameOnly (467.24s)
--- PASS: TestAccAWSLambdaFunction_nilDeadLetterConfig (46.34s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java11 (109.79s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_java8 (89.46s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs10x (417.73s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs12x (501.40s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_NodeJs810 (503.90s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_noRuntime (1.18s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_provided (76.07s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python27 (57.04s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python36 (63.71s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python37 (101.66s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_python38 (82.66s)
--- PASS: TestAccAWSLambdaFunction_runtimeValidation_ruby25 (96.18s)
--- PASS: TestAccAWSLambdaFunction_s3 (48.57s)
--- PASS: TestAccAWSLambdaFunction_s3Update_basic (70.87s)
--- PASS: TestAccAWSLambdaFunction_s3Update_unversioned (71.77s)
--- PASS: TestAccAWSLambdaFunction_tags (153.01s)
--- PASS: TestAccAWSLambdaFunction_tracingConfig (521.15s)
--- PASS: TestAccAWSLambdaFunction_updateRuntime (525.56s)
--- PASS: TestAccAWSLambdaFunction_versioned (262.52s)
--- PASS: TestAccAWSLambdaFunction_versionedUpdate (502.87s)
--- PASS: TestAccAWSLambdaFunction_VPC (1810.83s)
--- PASS: TestAccAWSLambdaFunction_VPC_withInvocation (1667.42s)
--- PASS: TestAccAWSLambdaFunction_VpcConfig_ProperIamDependencies (1378.09s)
--- PASS: TestAccAWSLambdaFunction_VPCRemoval (3110.44s)
--- PASS: TestAccAWSLambdaFunction_VPCUpdate (2027.87s)

[bflad]

This pull request was previously reviewed and testing passes, merging. 👍

[ghost]

This has been released in version 2.40.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ciaransweet]

@bflad I understand this has already been merged in, but I now get an error on previously working Lambda function creations:

Error: error waiting for Lambda Function (sentinel-find-images) creation: unexpected state '', wanted target 'Active'. last error: %!s(<nil>)

  on ../modules/lambda_functions/main.tf line 1, in resource "aws_lambda_function" "find-images":
   1: resource aws_lambda_function find-images {

This is being run against a LocalStack instance but I'm not sure that is the issue.

I've just pinned my aws provider to 2.39.0 and get:

module.lambda_functions.aws_lambda_function.find-images: Still creating... [10s elapsed]
module.lambda_functions.aws_lambda_function.find-images: Still creating... [20s elapsed]
module.lambda_functions.aws_lambda_function.find-images: Creation complete after 23s [id=sentinel-find-images]

[ewbankkit]

From the AWS SDK v1.25.42 release notes:

Added the function state and update status to the output of GetFunctionConfiguration and other actions. Check the state information to ensure that a function is ready before you perform operations on it. Functions take time to become ready when you connect them to a VPC.

Blog post.
Developer guide.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!