Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimun storage capacity size to 32GiB in resource, test, doc #11272

Merged

Conversation

mrgiles
Copy link
Contributor

@mrgiles mrgiles commented Dec 12, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11247

Release note for CHANGELOG:

Updates the storage_capacity minimum size from 300GiB to 32GiB, to reflect the current options available in the AWS console.

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSFsxWindowsFileSystem'
...
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (2782.98s)
--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (2849.85s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (2854.21s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (2903.37s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2966.89s)
--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (3095.36s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3227.16s)
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (3928.28s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4046.48s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (4103.13s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (4273.32s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (4287.93s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4288.049s

@mrgiles mrgiles requested a review from a team December 12, 2019 19:33
@ghost ghost added size/S Managed by automation to categorize the size of a PR. service/fsx Issues and PRs that pertain to the fsx service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. labels Dec 12, 2019
@mrgiles
Copy link
Contributor Author

mrgiles commented Dec 13, 2019

@bflad, do you think this will work to solve #11247 ? Thanks.

@mrgiles
Copy link
Contributor Author

mrgiles commented Dec 16, 2019

@slapula since you submitted the original code for FSx, would you mind taking a look? Thanks!

I noticed that it took several months for your code to be merged, so I guess I have a long wait ahead...

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 18, 2019
@bflad bflad self-assigned this Dec 18, 2019
@bflad bflad added this to the v2.43.0 milestone Dec 18, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this update, @mrgiles 🚀

Output from acceptance testing:

--- PASS: TestAccAWSFsxWindowsFileSystem_AutomaticBackupRetentionDays (2926.79s)
--- PASS: TestAccAWSFsxWindowsFileSystem_Tags (2944.99s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SelfManagedActiveDirectory (2953.44s)
--- PASS: TestAccAWSFsxWindowsFileSystem_DailyAutomaticBackupStartTime (2986.87s)
--- PASS: TestAccAWSFsxWindowsFileSystem_disappears (3001.66s)
--- PASS: TestAccAWSFsxWindowsFileSystem_basic (3075.06s)
--- PASS: TestAccAWSFsxWindowsFileSystem_WeeklyMaintenanceStartTime (3254.14s)
--- PASS: TestAccAWSFsxWindowsFileSystem_KmsKeyId (4020.49s)
--- PASS: TestAccAWSFsxWindowsFileSystem_ThroughputCapacity (4115.55s)
--- PASS: TestAccAWSFsxWindowsFileSystem_SecurityGroupIds (4197.55s)
--- PASS: TestAccAWSFsxWindowsFileSystem_StorageCapacity (4679.44s)
--- PASS: TestAccAWSFsxWindowsFileSystem_CopyTagsToBackups (4691.97s)

@bflad bflad merged commit b398a84 into hashicorp:master Dec 18, 2019
bflad added a commit that referenced this pull request Dec 18, 2019
@ghost
Copy link

ghost commented Dec 19, 2019

This has been released in version 2.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jan 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/fsx Issues and PRs that pertain to the fsx service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_fsx_windows_file_system minimum storage capacity does not match console
2 participants