Add prevent_user_existence_errors to cognito user pool client.

[claydanford]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11340

Release note for CHANGELOG:

resource/aws_cognito_user_pool_client: Add `prevent_user_existence_errors` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolClient'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPoolClient -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCognitoUserPoolClient_basic
=== PAUSE TestAccAWSCognitoUserPoolClient_basic
=== RUN   TestAccAWSCognitoUserPoolClient_RefreshTokenValidity
=== PAUSE TestAccAWSCognitoUserPoolClient_RefreshTokenValidity
=== RUN   TestAccAWSCognitoUserPoolClient_Name
=== PAUSE TestAccAWSCognitoUserPoolClient_Name
=== RUN   TestAccAWSCognitoUserPoolClient_allFields
=== PAUSE TestAccAWSCognitoUserPoolClient_allFields
=== RUN   TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField
=== CONT  TestAccAWSCognitoUserPoolClient_basic
=== CONT  TestAccAWSCognitoUserPoolClient_allFields
=== CONT  TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField
=== CONT  TestAccAWSCognitoUserPoolClient_Name
=== CONT  TestAccAWSCognitoUserPoolClient_RefreshTokenValidity
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (19.29s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (19.34s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (30.54s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (30.73s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (30.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.778s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.026s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.065s [no tests to run]
...

[realanmup]

PreventUserExistenceErrors has been now enabled by default. This might work as update to old Cognito clients.

[kdrapala]

@realanmup no it's not. Actually when i apply a terraform cognito then this option is setted to "Legacy"

[alkis-hexa]

I agree with @KacperDrapala it still goes on the Legacy option, so a fix is still required on this

[realanmup]

Exactly, for the old cognito client, the option should be manually enabled. This PR is as expected.
Thanks.

[claydanford]

@bflad, mind if we get a review of this small change?

Kindly,

CRD

[bacoboy]

Coming up on a month on this PR -- how do we push this across the finish line?

[claydanford]

Coming up on a month on this PR -- how do we push this across the finish line?

This needs some attention from someone who can review. I have suggested several people when adding a reviewer with no bites yet.

[Skyfallz]

@aeschright is it possible to get an update on this one please ? :) Thanks for your work.

[bflad]

Hi @claydanford 👋 Thank you for submitting this. See the below feedback and then we can get this in. Please reach out with any questions or if you do not have time to implement these items. 👍

[bflad]

Looks great, thank you so much, @claydanford 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPoolClient_disappears (8.86s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (9.71s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (10.04s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (14.09s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (14.44s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (14.81s)
--- PASS: TestAccAWSCognitoUserPoolClient_analyticsConfig (30.07s)

[ghost]

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!