Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_iot_topic_rule: Add support for 'operation' in DynamoDB action #12714

Merged
merged 1 commit into from
May 12, 2020

Conversation

kclccast
Copy link
Contributor

@kclccast kclccast commented Apr 7, 2020

This provider did not support the operation parameter when using a DynamoDB action on an IoT rule. This PR adds that support. It was already supported by the AWS SDK, so adding support for this was straightforward. Verified that tests pass with and without the optional operation parameter. Added a test to make sure the operation parameter is one of INSERT, UPDATE, or DELETE.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Adds "operation" support for the IoT Rule DyanmoDB action (INSERT, UPDATE, or DELETE).

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIoTTopicRule_dynamodb'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIoTTopicRule_dynamodb -timeout 120m
=== RUN   TestAccAWSIoTTopicRule_dynamodb
=== PAUSE TestAccAWSIoTTopicRule_dynamodb
=== CONT  TestAccAWSIoTTopicRule_dynamodb
--- PASS: TestAccAWSIoTTopicRule_dynamodb (35.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.164s
...

@kclccast kclccast requested a review from a team April 7, 2020 19:34
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 7, 2020
@kclccast kclccast changed the title IoT Rule DyanmoDB operation action r/aws_iot_topic_rule: Add support for 'operation' in DyanmoDB action Apr 8, 2020
@kclccast kclccast changed the title r/aws_iot_topic_rule: Add support for 'operation' in DyanmoDB action r/aws_iot_topic_rule: Add support for 'operation' in DynamoDB action Apr 8, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2020
@bflad bflad added this to the v2.62.0 milestone May 12, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kclccast 👋 Thank you for working on this and apologies for the delays getting it reviewed. We will be merging #7469, #9859, #9890, and #12714 at the same time to handle all the merge conflicts. 👍

@bflad bflad merged commit 0040086 into hashicorp:master May 12, 2020
bflad added a commit that referenced this pull request May 12, 2020
@ghost
Copy link

ghost commented May 15, 2020

This has been released in version 2.62.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jun 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants