Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Outpost) Add Local Gateway Route Table datasources #13002

Merged
merged 2 commits into from
May 1, 2020
Merged

(Outpost) Add Local Gateway Route Table datasources #13002

merged 2 commits into from
May 1, 2020

Conversation

johnbarney
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12302

Release note for CHANGELOG:

Adds Local Gateway Route Table(s) data source

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsLocalGatewayRouteTable'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsLocalGatewayRouteTable -timeout 120m
=== RUN   TestAccDataSourceAwsLocalGatewayRouteTable_basic
=== PAUSE TestAccDataSourceAwsLocalGatewayRouteTable_basic
=== RUN   TestAccDataSourceAwsLocalGatewayRouteTables_basic
=== PAUSE TestAccDataSourceAwsLocalGatewayRouteTables_basic
=== RUN   TestAccDataSourceAwsLocalGatewayRouteTables_filters
=== PAUSE TestAccDataSourceAwsLocalGatewayRouteTables_filters
=== CONT  TestAccDataSourceAwsLocalGatewayRouteTable_basic
=== CONT  TestAccDataSourceAwsLocalGatewayRouteTables_filters
=== CONT  TestAccDataSourceAwsLocalGatewayRouteTables_basic
--- PASS: TestAccDataSourceAwsLocalGatewayRouteTables_filters (53.06s)
--- PASS: TestAccDataSourceAwsLocalGatewayRouteTables_basic (53.30s)
--- PASS: TestAccDataSourceAwsLocalGatewayRouteTable_basic (53.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.959s

@johnbarney johnbarney requested a review from a team April 24, 2020 09:09
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 24, 2020
@ewbankkit
Copy link
Contributor

@johnbarney Thanks for this.
You'll need to add the new data sources to aws.erb to fix the Travis error:

https://github.com/terraform-providers/terraform-provider-aws/blob/e15190a93ee9399c4d5727e466d61cb8952a0285/website/aws.erb#L3174-L3182

@johnbarney
Copy link
Contributor Author

Requested changes done

$ make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsLocalGatewayRouteTable'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsLocalGatewayRouteTable -timeout 120m
=== RUN   TestAccDataSourceAwsLocalGatewayRouteTable_basic
=== PAUSE TestAccDataSourceAwsLocalGatewayRouteTable_basic
=== RUN   TestAccDataSourceAwsLocalGatewayRouteTables_basic
=== PAUSE TestAccDataSourceAwsLocalGatewayRouteTables_basic
=== RUN   TestAccDataSourceAwsLocalGatewayRouteTables_filters
=== PAUSE TestAccDataSourceAwsLocalGatewayRouteTables_filters
=== CONT  TestAccDataSourceAwsLocalGatewayRouteTable_basic
=== CONT  TestAccDataSourceAwsLocalGatewayRouteTables_filters
=== CONT  TestAccDataSourceAwsLocalGatewayRouteTables_basic
--- PASS: TestAccDataSourceAwsLocalGatewayRouteTables_filters (57.83s)
--- PASS: TestAccDataSourceAwsLocalGatewayRouteTables_basic (58.44s)
--- PASS: TestAccDataSourceAwsLocalGatewayRouteTable_basic (59.18s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.558s

@bflad bflad self-assigned this Apr 29, 2020
@bflad bflad added new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2020
@bflad bflad added this to the v2.61.0 milestone May 1, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johnbarney 👋 Thank you for submitting this! Overall this was another good contribution, only similar feedback and followup commit as #12852. Great work again.

Output from acceptance testing:

--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTable_Filter (16.03s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTable_OutpostArn (16.17s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTable_basic (17.74s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTable_LocalGatewayId (18.45s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTables_basic (16.03s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayRouteTables_Filter (17.66s)

@bflad bflad merged commit eeec56e into hashicorp:master May 1, 2020
bflad added a commit that referenced this pull request May 1, 2020
@johnbarney johnbarney deleted the outpost-localgatewayroutetable branch May 1, 2020 07:49
@ghost
Copy link

ghost commented May 8, 2020

This has been released in version 2.61.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 31, 2020
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants