Add Outpost attribute Support to all relevant resources

[DrFaust92]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add outpost to all relevant resources

New or Affected Resource(s)

• data_source_aws_subnet - add outpost support to subnet resource #12097
• data_source_aws_instance - Add outpost_arn to instance datasource #12330
• data_source_aws_ebs_volume - add outpost_arn field to data_source_aws_ebs_volume & resource_aws_ebs_volume #12439
• data_source_aws_network_interface - add outpost_arn field to data_source_aws_network_interface #12440
• resource_aws_subnet - add outpost support to subnet resource #12097
• resource_aws_ebs_volume - add outpost_arn field to data_source_aws_ebs_volume & resource_aws_ebs_volume #12439
• resource_aws_instance
• resource_aws_network_interface
• resource_aws_emr_cluster

References

https://aws.amazon.com/about-aws/whats-new/2019/12/announcing-general-availability-of-aws-outposts/

[ewbankkit]

We'll also need to support the associated networking components, local gateways and customer-owned address pools.

Potential data sources:

• aws_local_gateway, aws_local_gateways - Add Outpost Local Gateway support #12764
• aws_local_gateway_route_table, aws_local_gateway_route_tables - (Outpost) Add Local Gateway Route Table datasources #13002
• aws_ec2_local_gateway_route_table_vpc_association - New Resource: aws_ec2_local_gateway_route_table_vpc_association #13501
• aws_local_gateway_virtual_interface - New Data Source: aws_ec2_local_gateway_virtual_interface(s) #13504
• aws_local_gateway_virtual_interface_group - New Data Source: aws_ec2_local_gateway_virtual_interface_group #13502
• aws_coip_pool, aws_coip_pools - Add Datasource for COIP Pool(s) (Outpost) #12852

Potential resources:

• aws_local_gateway_route - New Resource: aws_ec2_local_gateway_route #13503
• aws_local_gateway_route_table_vpc_association - New Resource: aws_ec2_local_gateway_route_table_vpc_association #13501

Other affected resources:

• aws_route - resource/aws_route: Add LocalGatewayId attribute support #13888
• aws_route_table - resource/aws_route: Add LocalGatewayId attribute support #13888

[johnbarney]

I'll have time to take on some of these tasks. Would you prefer it in my current pull request #12097 or would you prefer a new PR per resource?

[DrFaust92]

I think that a PR per resource would be best.

…

On Tue, Mar 10, 2020, 15:01 John Barney ***@***.***> wrote: I'll have time to take on some of these tasks. Would you prefer it in my current pull request #12097 <#12097> or would you prefer a new PR per resource? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12302>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIA2W7RGQPTMCAD2VO3MQA3RGY23BANCNFSM4LDNTIOQ> .

[johnbarney]

Both resource_aws_instance and resource_aws_network_interface do not support outpost_arn parameter in the AWS API. I believe they inherit from being assigned to a subnet with outpost_arn assigned.

[johnbarney]

Both resource_aws_instance and resource_aws_network_interface do not support outpost_arn parameter in the AWS API. I believe they inherit from being assigned to a subnet with outpost_arn assigned.

Now that I have access to an Outpost, I've verified the above. Only Subnet and EBS Volume accept outpost_arn.

[DrFaust92]

Both resource_aws_instance and resource_aws_network_interface do not support outpost_arn parameter in the AWS API. I believe they inherit from being assigned to a subnet with outpost_arn assigned.

seems like it, but they have a read only field that can be set to computed.

[johnbarney]

seems like it, but they have a read only field that can be set to computed.

Good point. Added to my Instance PR to include this. Will add it to ENI as well.

[johnbarney]

Now that you guys have Outpost access (I think you guys actually have access to the same one I do), please let me know what resources I can contribute without duplicating efforts with your team. I'm working on the back end to get approval for continued support for this ticket.

[bflad]

Hi @johnbarney 👋 If you're able and willing, it might be great for you to pick up the EC2 Local Gateway Virtual Interface (Group) data source support! The implementation for those will be similar to your previous (much appreciated!) contributions. 🎉

The EC2 API just added some additional EC2 Subnet + COIP support, which I created separate issues for: #13170 / #13171

We also may want to consider closing this issue and creating separate ones for the remaining functionality, just so we can more easily assign folks and have good definitions for "done". For now I'll leave it though.

[bflad]

Hi folks 👋 Please note that this issue is being split to ensure we have a definition of done for each unit of work since "support all X" issues tend to introduce scope creep over time.

I have created the following feature request issues:

• New Resource: aws_ec2_local_gateway_route_table_vpc_association: New Resource: aws_ec2_local_gateway_route_table_vpc_association #13501
• New Data Source: aws_ec2_local_gateway_virtual_interface_group: New Data Source: aws_ec2_local_gateway_virtual_interface_group #13502
• New Resource: aws_ec2_local_gateway_route: New Resource: aws_ec2_local_gateway_route #13503
• New Data Source: aws_ec2_local_gateway_virtual_interface(s): New Data Source: aws_ec2_local_gateway_virtual_interface(s) #13504

If you have needs for other enhancements, please create new GitHub issues following the feature request template. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!