Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_subnet: Add customer_owned_ipv4_pool and map_customer_owned_ip_on_launch arguments #13170

Closed
bflad opened this issue May 5, 2020 · 4 comments · Fixed by #16676
Closed

resource/aws_subnet: Add customer_owned_ipv4_pool and map_customer_owned_ip_on_launch arguments #13170

bflad opened this issue May 5, 2020 · 4 comments · Fixed by #16676
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v3.27.0

Comments

@bflad
Copy link
Contributor

bflad commented May 5, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Go SDK v1.30.21 includes additional functionality for AWS Outposts, suitable for the aws_subnet resource.

Affected Resource

  • aws_subnet

Potential Terraform Configuration

resource "aws_subnet" "example" {
  cidr_block                      = "..."
  customer_owned_ipv4_pool        = data.aws_ec2_coip_pool.example.id
  map_customer_owned_ip_on_launch = true
  outpost_arn                     = "arn:..."
}

References
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label May 5, 2020
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label May 5, 2020
@bflad bflad mentioned this issue May 6, 2020
Closed
9 tasks
@bflad bflad self-assigned this May 6, 2020
@bflad
Copy link
Contributor Author

bflad commented May 6, 2020

While this is supported in the SDK, it does not appear to be deployed to us-west-2 yet. Sending any combination of CustomerOwnedIpv4Pool and MapCustomerOwnedIpOnLaunch to the ModifySubnetAttributes call returns the following error:

MissingParameter: No valid attributes specified.

They are also missing from the DescribeSubnets response.

bflad added a commit that referenced this issue May 6, 2020
@bflad
service/ec2: Add customer_owned_ipv4_pool and map_customer_owned_ip_o…
666de05 
…n_launch attributes to aws_subnet data source and resource

Reference: #13170
Reference: #13171

Output from acceptance testing:

```
Pending us-west-2 deployment of EC2 API.
```
@bflad bflad mentioned this issue May 6, 2020
Closed
bflad added a commit that referenced this issue Jun 16, 2020
@bflad
service/ec2: Add customer_owned_ipv4_pool and map_customer_owned_ip_o…
ace6c32 
…n_launch attributes to aws_subnet data source and resource

Reference: #13170
Reference: #13171

Output from acceptance testing:

```
Pending us-west-2 deployment of EC2 API.
```
@bflad bflad removed their assignment Aug 25, 2020
@ewbankkit ewbankkit mentioned this issue Nov 20, 2020
Closed
@FireballDWF
Copy link

This support is needed for instances launched in ASG's to get CoIPs

bflad added a commit that referenced this issue Dec 9, 2020
@bflad
service/ec2: Add COIP support to aws_subnet resource and data source
03e1f42 
Reference: #13170
Reference: #13171

Output from acceptance testing in OTL account:

```
--- PASS: TestAccDataSourceAwsSubnet_basic (25.67s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (46.37s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (51.83s)

--- PASS: TestAccAWSSubnet_availabilityZoneId (29.12s)
--- PASS: TestAccAWSSubnet_basic (31.04s)
--- PASS: TestAccAWSSubnet_CustomerOwnedIpv4Pool (63.80s)
--- PASS: TestAccAWSSubnet_disappears (21.79s)
--- PASS: TestAccAWSSubnet_enableIpv6 (79.03s)
--- PASS: TestAccAWSSubnet_ignoreTags (45.48s)
--- PASS: TestAccAWSSubnet_ipv6 (90.26s)
--- PASS: TestAccAWSSubnet_MapCustomerOwnedIpOnLaunch (49.07s)
--- PASS: TestAccAWSSubnet_outpost (47.45s)
--- PASS: TestAccAWSSubnet_tags (68.74s)
```
bflad added a commit that referenced this issue Dec 9, 2020
@bflad
service/ec2: Add COIP support to aws_subnet resource and data source
f1a02bc 
Reference: #13170
Reference: #13171

Output from acceptance testing in OTL account:

```
--- PASS: TestAccDataSourceAwsSubnet_basic (25.67s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (46.37s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (51.83s)

--- PASS: TestAccAWSSubnet_availabilityZoneId (29.12s)
--- PASS: TestAccAWSSubnet_basic (31.04s)
--- PASS: TestAccAWSSubnet_CustomerOwnedIpv4Pool (63.80s)
--- PASS: TestAccAWSSubnet_disappears (21.79s)
--- PASS: TestAccAWSSubnet_enableIpv6 (79.03s)
--- PASS: TestAccAWSSubnet_ignoreTags (45.48s)
--- PASS: TestAccAWSSubnet_ipv6 (90.26s)
--- PASS: TestAccAWSSubnet_MapCustomerOwnedIpOnLaunch (49.07s)
--- PASS: TestAccAWSSubnet_outpost (47.45s)
--- PASS: TestAccAWSSubnet_tags (68.74s)
```
@bflad bflad mentioned this issue Dec 9, 2020
Merged
bflad added a commit that referenced this issue Jan 29, 2021
@bflad
service/ec2: Add COIP support to aws_subnet resource and data source (#…
afa5e87 
…16676)

* service/ec2: Add COIP support to aws_subnet resource and data source

Reference: #13170
Reference: #13171

Output from acceptance testing in OTL account:

```
--- PASS: TestAccDataSourceAwsSubnet_basic (25.67s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6CidrBlock (46.37s)
--- PASS: TestAccDataSourceAwsSubnet_ipv6ByIpv6Filter (51.83s)

--- PASS: TestAccAWSSubnet_availabilityZoneId (29.12s)
--- PASS: TestAccAWSSubnet_basic (31.04s)
--- PASS: TestAccAWSSubnet_CustomerOwnedIpv4Pool (63.80s)
--- PASS: TestAccAWSSubnet_disappears (21.79s)
--- PASS: TestAccAWSSubnet_enableIpv6 (79.03s)
--- PASS: TestAccAWSSubnet_ignoreTags (45.48s)
--- PASS: TestAccAWSSubnet_ipv6 (90.26s)
--- PASS: TestAccAWSSubnet_MapCustomerOwnedIpOnLaunch (49.07s)
--- PASS: TestAccAWSSubnet_outpost (47.45s)
--- PASS: TestAccAWSSubnet_tags (68.74s)
```

* Update CHANGELOG for #16676

* Fix typo in CHANGELOG
@github-actions github-actions bot added this to the v3.27.0 milestone Jan 29, 2021
@ghost
Copy link

ghost commented Feb 5, 2021

This has been released in version 3.27.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Feb 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v3.27.0
2 participants
@FireballDWF @bflad