Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: aws_ec2_local_gateway_route_table_vpc_association #13501

Closed
bflad opened this issue May 26, 2020 · 8 comments · Fixed by #13765
Closed

New Resource: aws_ec2_local_gateway_route_table_vpc_association #13501

bflad opened this issue May 26, 2020 · 8 comments · Fixed by #13765
Assignees
Labels
new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@bflad
Copy link
Contributor

bflad commented May 26, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support the ability to manage EC2 Local Gateway Route Table VPC Associations, connecting Outposts to VPCs.

New Resource

  • aws_ec2_local_gateway_route_table_vpc_association

Potential Terraform Configuration

resource "aws_ec2_local_gateway_route_table_vpc_association" "example" {
  local_gateway_route_table_id = data.aws_ec2_local_gateway_route_table.example.id
  vpc_id                       = aws_vpc.example.id
}

References

@bflad bflad added new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 26, 2020
@bflad bflad self-assigned this May 26, 2020
@FireballDWF
Copy link

@bflad If you want help testing this on an actual Outpost, send me a test build of the provider and I can likely turn around results in a day

@bflad
Copy link
Contributor Author

bflad commented May 29, 2020

@FireballDWF very much appreciate the offer! It looks like we'll have access to an AWS Outposts lab again June 3rd-5th, but it would be nice to get ahead of that. 😄

@martinsmatthews
Copy link

Also happy to help test, right now I'm doing this manually but all the other bits for setting up our outpost using tf

@FireballDWF
Copy link

@bflad Do you have code ready for me to test?

bflad added a commit that referenced this issue Jun 15, 2020
Reference: #13501

Output from acceptance testing:

```
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_basic (35.14s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_disappears (37.27s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_Tags (74.40s)
```
@bflad
Copy link
Contributor Author

bflad commented Jun 15, 2020

Hey @FireballDWF / @martinsmatthews -- code can now be found at #13765. Please reach out to me at my username at hashicorp dot com if you need me to provide you a build directly (with which OS/arch), otherwise we have instructions available in the Development Guide. Thanks!

@bflad bflad added this to the v2.67.0 milestone Jun 17, 2020
bflad added a commit that referenced this issue Jun 17, 2020
Reference: #13501

Output from acceptance testing:

```
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_basic (35.14s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_disappears (37.27s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_Tags (74.40s)
```
@bflad
Copy link
Contributor Author

bflad commented Jun 17, 2020

Support for this new resource has been merged and will release with version 2.67.0 of the Terraform AWS Provider, likely tomorrow. 👍

@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants