Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_ec2_local_gateway_route_table_vpc_association #13765

Merged
merged 1 commit into from
Jun 17, 2020
Merged

New Resource: aws_ec2_local_gateway_route_table_vpc_association #13765

merged 1 commit into from
Jun 17, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 15, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13501

Release note for CHANGELOG:

* **New Resource:** `aws_ec2_local_gateway_route_table_vpc_association`

Output from acceptance testing:

--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_basic (35.14s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_disappears (37.27s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_Tags (74.40s)

@bflad
New Resource: aws_ec2_local_gateway_route_table_vpc_association
89546d3 
Reference: #13501

Output from acceptance testing:

```
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_basic (35.14s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_disappears (37.27s)
--- PASS: TestAccAwsEc2LocalGatewayRouteTableVpcAssociation_Tags (74.40s)
```
@bflad bflad added the new-resource Introduces a new resource. label Jun 15, 2020
@bflad bflad requested a review from a team June 15, 2020 22:59
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jun 15, 2020
@bflad bflad mentioned this pull request Jun 15, 2020
Closed
@anGie44 anGie44 self-requested a review June 17, 2020 14:15
anGie44
anGie44 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment otherwise LGTM 👍

Skipping acceptance test output given the env variable

aws/resource_aws_ec2_local_gateway_route_table_vpc_association.go
conn := meta.(*AWSClient).ec2conn
ignoreTagsConfig := meta.(*AWSClient).IgnoreTagsConfig

association, err := getEc2LocalGatewayRouteTableVpcAssociation(conn, d.Id())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an aside: could we re-use the LocalGatewayRouteTableVpcAssociationState method in the waiter package or would that be a bit unreadable (also in the Exists/Destroy methods of the test file)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a decent idea, but a little confusing usage-wise since its conflating two use cases as sometimes the RefreshStateFunc will have special error handling logic that may not be desirable for other uses. I think @gdavison and I are converging on having some form an internal service package that contains consistently named Get{THING} functions that the Read, testAccCheck{THING}Exists, testAccCheck{THING}Destroy, and the waiter package functions will all commonly use. 👍

@bflad bflad added this to the v2.67.0 milestone Jun 17, 2020
@bflad bflad merged commit 1f26314 into master Jun 17, 2020
@bflad bflad deleted the f-aws_ec2_local_gateway_route_table_vpc_association branch June 17, 2020 17:17
bflad added a commit that referenced this pull request Jun 17, 2020
@bflad
Update CHANGELOG for #13765
cc9eec4
@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging this pull request may close these issues.

New Resource: aws_ec2_local_gateway_route_table_vpc_association
2 participants
@bflad @anGie44