Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add outpost_arn field to data_source_aws_ebs_volume & resource_aws_ebs_volume #12439

Merged
merged 5 commits into from
Apr 29, 2020
Merged

add outpost_arn field to data_source_aws_ebs_volume & resource_aws_ebs_volume #12439

merged 5 commits into from
Apr 29, 2020

Conversation

johnbarney
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #12302

Release note for CHANGELOG:

Add outpost_arn support for EBS volume resource
Add outpost_arn support for EBS volume datasource

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEbsVolumeDataSource_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEbsVolumeDataSource_basic -timeout 120m
=== RUN   TestAccAWSEbsVolumeDataSource_basic
=== PAUSE TestAccAWSEbsVolumeDataSource_basic
=== CONT  TestAccAWSEbsVolumeDataSource_basic
--- PASS: TestAccAWSEbsVolumeDataSource_basic (72.07s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       73.812s

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume -timeout 120m
=== RUN   TestAccAWSEBSVolume_basic
=== PAUSE TestAccAWSEBSVolume_basic
=== RUN   TestAccAWSEBSVolume_updateAttachedEbsVolume
=== PAUSE TestAccAWSEBSVolume_updateAttachedEbsVolume
=== RUN   TestAccAWSEBSVolume_updateSize
=== PAUSE TestAccAWSEBSVolume_updateSize
=== RUN   TestAccAWSEBSVolume_updateType
=== PAUSE TestAccAWSEBSVolume_updateType
=== RUN   TestAccAWSEBSVolume_updateIops
=== PAUSE TestAccAWSEBSVolume_updateIops
=== RUN   TestAccAWSEBSVolume_kmsKey
=== PAUSE TestAccAWSEBSVolume_kmsKey
=== RUN   TestAccAWSEBSVolume_NoIops
=== PAUSE TestAccAWSEBSVolume_NoIops
=== RUN   TestAccAWSEBSVolume_withTags
=== PAUSE TestAccAWSEBSVolume_withTags
=== RUN   TestAccAWSEBSVolume_outpost
    TestAccAWSEBSVolume_outpost: resource_aws_ebs_volume_test.go:322: Environment variable AWS_OUTPOST_ARN is not set. This environment variable must be set to the ARN of a deployed Outpost to enable this test.
--- SKIP: TestAccAWSEBSVolume_outpost (0.00s)
=== CONT  TestAccAWSEBSVolume_basic
=== CONT  TestAccAWSEBSVolume_kmsKey
=== CONT  TestAccAWSEBSVolume_updateType
=== CONT  TestAccAWSEBSVolume_updateAttachedEbsVolume
=== CONT  TestAccAWSEBSVolume_withTags
=== CONT  TestAccAWSEBSVolume_NoIops
=== CONT  TestAccAWSEBSVolume_updateSize
=== CONT  TestAccAWSEBSVolume_updateIops
--- PASS: TestAccAWSEBSVolume_basic (63.41s)
--- PASS: TestAccAWSEBSVolume_withTags (63.77s)
--- PASS: TestAccAWSEBSVolume_NoIops (63.77s)
--- PASS: TestAccAWSEBSVolume_kmsKey (104.87s)
--- PASS: TestAccAWSEBSVolume_updateType (111.89s)
--- PASS: TestAccAWSEBSVolume_updateIops (111.98s)
--- PASS: TestAccAWSEBSVolume_updateSize (112.24s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (272.61s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       274.205s

@johnbarney johnbarney requested a review from a team March 18, 2020 04:49
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/ec2 Issues and PRs that pertain to the ec2 service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 18, 2020
@johnbarney
Copy link
Contributor Author

Verified EBS volume creation on Outpost

$ AWS_OUTPOST_ARN=arn:aws:outposts:us-west-2:<snip>>:outpost/op-<snip> make testacc TEST=./aws TESTARGS='-run=TestAccAWSEBSVolume_outpost'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEBSVolume_outpost -timeout 120m
=== RUN   TestAccAWSEBSVolume_outpost
=== PAUSE TestAccAWSEBSVolume_outpost
=== CONT  TestAccAWSEBSVolume_outpost
--- PASS: TestAccAWSEBSVolume_outpost (76.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	79.223s

@bflad bflad self-assigned this Apr 29, 2020
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 29, 2020
@bflad bflad added this to the v2.60.0 milestone Apr 29, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @johnbarney! 🚀

Output from acceptance testing:

--- PASS: TestAccAWSEBSVolume_basic (32.15s)
--- PASS: TestAccAWSEBSVolume_kmsKey (59.63s)
--- PASS: TestAccAWSEBSVolume_NoIops (32.87s)
--- PASS: TestAccAWSEBSVolume_outpost (33.47s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (161.35s)
--- PASS: TestAccAWSEBSVolume_updateIops (56.55s)
--- PASS: TestAccAWSEBSVolume_updateSize (56.66s)
--- PASS: TestAccAWSEBSVolume_updateType (57.17s)
--- PASS: TestAccAWSEBSVolume_withTags (30.70s)

--- PASS: TestAccAWSEbsVolumeDataSource_basic (31.21s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (32.13s)

@bflad bflad merged commit 32be86a into hashicorp:master Apr 29, 2020
bflad added a commit that referenced this pull request Apr 29, 2020
@johnbarney johnbarney deleted the outpost-ebs-volume branch April 29, 2020 17:58
@ghost
Copy link

ghost commented May 1, 2020

This has been released in version 2.60.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

adamdecaf pushed a commit to adamdecaf/terraform-provider-aws that referenced this pull request May 28, 2020
… data source (hashicorp#12439)

Output from acceptance testing:

```
--- PASS: TestAccAWSEBSVolume_basic (32.15s)
--- PASS: TestAccAWSEBSVolume_kmsKey (59.63s)
--- PASS: TestAccAWSEBSVolume_NoIops (32.87s)
--- PASS: TestAccAWSEBSVolume_outpost (33.47s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (161.35s)
--- PASS: TestAccAWSEBSVolume_updateIops (56.55s)
--- PASS: TestAccAWSEBSVolume_updateSize (56.66s)
--- PASS: TestAccAWSEBSVolume_updateType (57.17s)
--- PASS: TestAccAWSEBSVolume_withTags (30.70s)

--- PASS: TestAccAWSEbsVolumeDataSource_basic (31.21s)
--- PASS: TestAccAWSEbsVolumeDataSource_multipleFilters (32.13s)
```
@ghost
Copy link

ghost commented May 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 29, 2020
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants