Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/aws_availability_zones: Remove blacklisted_names and blacklisted_zone_ids arguments #14134

Merged
merged 1 commit into from
Jul 14, 2020
Merged

data-source/aws_availability_zones: Remove blacklisted_names and blacklisted_zone_ids arguments #14134

merged 1 commit into from
Jul 14, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 10, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #13766

Release note for CHANGELOG:

* data-source/aws_availability_zones: Remove `blacklisted_names` and `blacklisted_zone_ids` arguments

Output from acceptance testing:

--- PASS: TestAccAWSAvailabilityZones_basic (15.27s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (15.46s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (15.58s)
--- PASS: TestAccAWSAvailabilityZones_Filter (15.70s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (17.01s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (17.17s)

@bflad
data-source/aws_availability_zones: Remove blacklisted_names and blac…
d49f5d3 
…klisted_zone_ids arguments

Reference: #13766

Output from acceptance testing:

```
--- PASS: TestAccAWSAvailabilityZones_basic (15.27s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (15.46s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (15.58s)
--- PASS: TestAccAWSAvailabilityZones_Filter (15.70s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (17.01s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (17.17s)
```
@bflad bflad added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jul 10, 2020
@bflad bflad added this to the v3.0.0 milestone Jul 10, 2020
@bflad bflad requested a review from a team July 10, 2020 02:05
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 10, 2020
@hashicorp hashicorp locked and limited conversation to collaborators Jul 10, 2020
anGie44
anGie44 approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Output of acceptance tests:

=== CONT  TestAccAWSAvailabilityZones_AllAvailabilityZones
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (16.83s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (17.00s)
--- PASS: TestAccAWSAvailabilityZones_basic (17.01s)
--- PASS: TestAccAWSAvailabilityZones_Filter (17.06s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (18.50s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (18.69s)

@bflad bflad merged commit ab23d14 into master Jul 14, 2020
@bflad bflad deleted the td-aws_availability_zones-remove-blacklisted branch July 14, 2020 22:00
@ghost
Copy link

ghost commented Jul 31, 2020

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost ghost unlocked this conversation Jul 31, 2020
@ghost ghost locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Remove non-inclusive terminology from aws_availability_zones data source attribute names
2 participants
@bflad @anGie44