Remove non-inclusive terminology from aws_availability_zones data source attribute names

[breathingdust]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Use the next major release as an opportunity to remove non-inclusive terminology in the provider codebase, documentation, and examples. We will be removing words whose meanings, origin, or associations are contrary to our Principles.

New or Affected Resource(s)

• aws_availability_zones

Potential Terraform Configuration

Before:

data "aws_availability_zones" "test" {
  blacklisted_zone_ids = []
  blacklisted_names = []
}

After:

data "aws_availability_zones" "test" {
  skip_zone_ids = []
  skip_names = []
}

References

• HashiCorp Principles

[bflad]

First pass: #13771

[chrisfowles]

Ironically exclude is probably better and less ambiguous terminology here.

i.e.

data "aws_availability_zones" "test" {
  exclude_zone_ids = []
  exclude_names = []
}

[myoung34]

skip has some connotations to it about not being evaluated.
exclude makes more sense as a replacment term

[clort81]

This offends me.

[chrisfowles]

@myoung34 - while i agree they're similar, I feel that the intended action inflects different intents on the terms.

skip has some connotations to it about not being evaluated.
exclude makes more sense as a replacement term

in my understanding of common parlance:

skip is something that you do over a single item or set of items in a collection that you are iterating through. The connotations for skip for filtering are usually in terms of a number of records.

e.g. i want to read the this file but skip the first 2 lines.

exclude makes more sense on a data source as a filter.

e.g. i want to read this file but exclude any lines starting with cat.

[paultyng]

@clort81 I edited your comment, the original comment was not in line with our community guidelines

People are free to discuss the technical considerations of this change, but as @breathingdust states in the original post, this is to bring the code in line with our internal standards, not a dicussion of what those standards are.

[paultyng]

@lukashin this is a pretty bad faith reading of everything being discussed. The original post lists the specifics, and the referenced changes are a single data source and NOT upstream AWS API rendering much of your comments here moot.

I've hidden your response as it was also explicitly counter to what I previously said that this issue is not for discussion of the standards. Please refrain from further similar comments elsewhere.

[bflad]

Removal of the deprecated aws_availabiliity_zones arguments has been merged and will be released with version 3.0.0 of the Terraform AWS Provider, in about two weeks.

[ghost]

This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!