Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: First pass at removing non-inclusive terminology #13771

Merged
merged 3 commits into from
Jun 26, 2020
Merged

provider: First pass at removing non-inclusive terminology #13771

merged 3 commits into from
Jun 26, 2020

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jun 16, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: #13766

Release note for CHANGELOG:

* data-source/aws_availability_zones: Deprecate `blacklisted_` arguments for `exclude_` arguments

Output from acceptance testing:

--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (18.12s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (18.20s)
--- PASS: TestAccAWSAvailabilityZones_Filter (18.30s)
--- PASS: TestAccAWSAvailabilityZones_basic (18.32s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (19.82s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (20.00s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (20.04s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (20.14s)

@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 16, 2020
@bflad bflad requested a review from a team June 16, 2020 02:10
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. examples Introduces or discusses updates to examples. provider Pertains to the provider itself, rather than any interaction with AWS. service/applicationautoscaling service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/codebuild Issues and PRs that pertain to the codebuild service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 16, 2020
@bflad bflad mentioned this pull request Jun 16, 2020
Closed
@anGie44 anGie44 self-requested a review June 18, 2020 19:17
anGie44
anGie44 approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ❤️ ! my only comment for discussion would be in regard to the naming. not that we have to follow-suit with how others have approached the white/blacklist, master/slave terminology replacements, but I'm also a fan of the approach taken by the Go community https://go-review.googlesource.com/c/go/+/236857 such that they've used allow/block which might be a bit more self-explanatory

bflad added 3 commits June 23, 2020 14:52
@bflad
provider: First pass at removing non-inclusive terminology
abffcb6 
Reference: #13766

Changes:

* data-source/aws_availability_zones: Deprecate blacklisted_ arguments for skip_ arguments

Output from acceptance testing:

```
--- PASS: TestAccAWSAvailabilityZones_stateFilter (16.19s)
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (16.22s)
--- PASS: TestAccAWSAvailabilityZones_Filter (16.33s)
--- PASS: TestAccAWSAvailabilityZones_basic (16.52s)
--- PASS: TestAccAWSAvailabilityZones_SkipZoneIds (17.68s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (17.75s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (18.07s)
--- PASS: TestAccAWSAvailabilityZones_SkipNames (18.19s)
```
@bflad
docs/provider: Add aws_availability_zones removals to version 3 guide
a897caf
@bflad
data-source/aws_availability_zones: Switch skip_* naming to exclude_*
d259af4 
Output from acceptance testing:

```
--- PASS: TestAccAWSAvailabilityZones_AllAvailabilityZones (18.12s)
--- PASS: TestAccAWSAvailabilityZones_stateFilter (18.20s)
--- PASS: TestAccAWSAvailabilityZones_Filter (18.30s)
--- PASS: TestAccAWSAvailabilityZones_basic (18.32s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeZoneIds (19.82s)
--- PASS: TestAccAWSAvailabilityZones_ExcludeNames (20.00s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedNames (20.04s)
--- PASS: TestAccAWSAvailabilityZones_BlacklistedZoneIds (20.14s)
```
@bflad bflad force-pushed the f-aws_availability_zones-add-skip-args branch from 9522cd8 to d259af4 Compare June 23, 2020 19:05
@bflad
Copy link
Contributor Author

bflad commented Jun 23, 2020

Rebased and switched skip_* naming in aws_availability_zones data source to exclude_*

@bflad bflad added this to the v2.69.0 milestone Jun 26, 2020
@bflad bflad merged commit 23066a5 into master Jun 26, 2020
@bflad bflad deleted the f-aws_availability_zones-add-skip-args branch June 26, 2020 20:12
bflad added a commit that referenced this pull request Jun 26, 2020
@bflad
Update CHANGELOG for #13771
805eb7c
@ghost
Copy link

ghost commented Jul 3, 2020

This has been released in version 2.69.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@haidangwa

This comment has been minimized.

Sign in to view
@hashicorp hashicorp locked and limited conversation to collaborators Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. examples Introduces or discusses updates to examples. provider Pertains to the provider itself, rather than any interaction with AWS. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/codebuild Issues and PRs that pertain to the codebuild service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.69.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bflad @haidangwa @anGie44