Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: aws_s3control_bucket_policy #15416

Closed
bflad opened this issue Oct 1, 2020 · 3 comments · Fixed by #15575
Closed

New Resource: aws_s3control_bucket_policy #15416

bflad opened this issue Oct 1, 2020 · 3 comments · Fixed by #15575
Assignees
@bflad
Labels
new-resource Introduces a new resource. service/s3control Issues and PRs that pertain to the s3control service.
Milestone
v3.13.0

Comments

@bflad
Copy link
Contributor

bflad commented Oct 1, 2020 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

As part of the initial S3 on Outposts support for the Terraform AWS Provider, a new resource for managing Bucket Policies in the S3 Control API is necessary. This new resource does not deprecate the existing aws_s3_bucket/aws_s3_bucket_policy resource functionality and does not represent any operator need for migration between the two. Resource documentation call out boxes will be in place to help delineate the purpose of the two similar, but different resources.

New Resource

  • aws_s3control_bucket_policy

Potential Terraform Configuration

resource "aws_s3control_bucket_policy" "example" {
  bucket = aws_s3control_bucket.example.bucket
  policy = "{...}"
}

References
@bflad bflad added new-resource Introduces a new resource. service/s3control Issues and PRs that pertain to the s3control service. labels Oct 1, 2020
@bflad bflad self-assigned this Oct 1, 2020
@bflad bflad mentioned this issue Oct 1, 2020
Closed
bflad added a commit that referenced this issue Oct 9, 2020
@bflad
New Resource: aws_s3control_bucket_policy
17f8c24 
Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```
@bflad bflad mentioned this issue Oct 9, 2020
Merged
bflad added a commit that referenced this issue Oct 12, 2020
@bflad
New Resource: aws_s3control_bucket_policy
7a9ee7c 
Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```
bflad added a commit that referenced this issue Oct 12, 2020
@bflad
New Resource: aws_s3control_bucket_policy
947354f 
Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```
bflad added a commit that referenced this issue Oct 16, 2020
@bflad
New Resource: aws_s3control_bucket_policy
c663667 
Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```
bflad added a commit that referenced this issue Oct 16, 2020
@bflad
New Resource: aws_s3control_bucket_policy
cbd7c0d 
Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```
@bflad bflad added this to the v3.13.0 milestone Oct 27, 2020
bflad added a commit that referenced this issue Oct 27, 2020
@bflad
New Resource: aws_s3control_bucket_policy (#15575)
24b5475 
* New Resource: aws_s3control_bucket_policy

Reference: #15412
Reference: #15416

Output from acceptance testing:

```
Pending
```

* tests/resource/aws_s3control_bucket_policy: Fixes since Public Access Block is always enabled for S3 Control Buckets

Output from acceptance testing:

```
--- PASS: TestAccAWSS3ControlBucketPolicy_disappears (32.85s)
--- PASS: TestAccAWSS3ControlBucketPolicy_Policy (43.13s)
--- PASS: TestAccAWSS3ControlBucketPolicy_basic (106.91s)
```

* resource/aws_s3control_bucket_policy: terrafmt fixes

* Update aws/resource_aws_s3control_bucket_policy_test.go
@bflad
Copy link
Contributor Author

bflad commented Oct 27, 2020

Support for this new resource has been merged and will release with version 3.13.0 of the Terraform AWS Provider, later this week. 👍

@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
new-resource Introduces a new resource. service/s3control Issues and PRs that pertain to the s3control service.
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging a pull request may close this issue.

New Resource: aws_s3control_bucket_policy hashicorp/terraform-provider-aws
1 participant
@bflad