Add tags support to aws_nat_gateway resource

[ewbankkit]

Fixes #1624.

[ewbankkit]

Acceptance test:

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSNatGateway_tags'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -run=TestAccAWSNatGateway_tags -timeout 120m
=== RUN   TestAccAWSNatGateway_tags
--- PASS: TestAccAWSNatGateway_tags (242.09s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	242.098s

[Ninir]

Hi @ewbankkit

Thanks for the work here! 👍
Just left 2 small comments of really small importance.

Tell me what you think!

Thanks :)

[Ninir]

The else is not needed since the if returns

[ewbankkit]

Done.

[Ninir]

Small nitpick: can you fix the indentation through the tests here? perhaps using 2 spaces, so that it is consistent with other ones?

Thanks!

[ewbankkit]

Done.

[Ninir]

Hey @ewbankkit

This looks very good to me!

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSNatGateway_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSNatGateway_ -timeout 120m
=== RUN   TestAccAWSNatGateway_importBasic
--- PASS: TestAccAWSNatGateway_importBasic (212.37s)
=== RUN   TestAccAWSNatGateway_basic
--- PASS: TestAccAWSNatGateway_basic (190.04s)
=== RUN   TestAccAWSNatGateway_tags
--- PASS: TestAccAWSNatGateway_tags (225.70s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	628.147s

Thanks a lot for your work! 👍 :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!