Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sns_topic: Add support of prefixes #2753

Merged
merged 4 commits into from
Feb 6, 2018

Conversation

ColinHebert
Copy link
Contributor

No description provided.

@jen20 jen20 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 22, 2017
@ColinHebert ColinHebert changed the title Add support of prefixes for aws_sns_topic r/aws_sns_topic: Add support of prefixes Dec 28, 2017
@bflad bflad added the service/sns Issues and PRs that pertain to the sns service. label Jan 28, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ColinHebert thanks so much for this enhancement! Sorry it took so long to get reviewed. This PR looks great and thanks for including the additional acceptance test. I'll actually be including an additional one to make sure the generated name bits are okay (which they are 😄 ).

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopic_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSNSTopic_ -timeout 120m
=== RUN   TestAccAWSSNSTopic_importBasic
--- PASS: TestAccAWSSNSTopic_importBasic (11.68s)
=== RUN   TestAccAWSSNSTopic_basic
--- PASS: TestAccAWSSNSTopic_basic (9.02s)
=== RUN   TestAccAWSSNSTopic_name
--- PASS: TestAccAWSSNSTopic_name (10.67s)
=== RUN   TestAccAWSSNSTopic_namePrefix
--- PASS: TestAccAWSSNSTopic_namePrefix (9.51s)
=== RUN   TestAccAWSSNSTopic_policy
--- PASS: TestAccAWSSNSTopic_policy (10.46s)
=== RUN   TestAccAWSSNSTopic_withIAMRole
--- PASS: TestAccAWSSNSTopic_withIAMRole (29.56s)
=== RUN   TestAccAWSSNSTopic_withFakeIAMRole
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (66.70s)
=== RUN   TestAccAWSSNSTopic_withDeliveryPolicy
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (10.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	157.691s

@bflad bflad added this to the v1.9.0 milestone Feb 6, 2018
…me generated/name/name_prefix bits for clarity
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 6, 2018
@bflad bflad merged commit fff1145 into hashicorp:master Feb 6, 2018
bflad added a commit that referenced this pull request Feb 6, 2018
@bflad
Copy link
Contributor

bflad commented Feb 9, 2018

This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sns Issues and PRs that pertain to the sns service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants