r/api_gateway_stage: Support tags #2858
Conversation
Ninir
added
the
enhancement
bflad
added
the
service/apigateway
|
Hi whats the progress of this PR? |
|
Sorry for late. |
atsushi-ishibashi
changed the title
There was a problem hiding this comment.
Sorry for the long overdue review of this PR 😅 -- looks great. 🚀
After fixing the removed function:
make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayStage'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayStage -timeout 120m
=== RUN TestAccAWSAPIGatewayStage_basic
--- PASS: TestAccAWSAPIGatewayStage_basic (591.80s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 591.841s
| @@ -180,6 +189,19 @@ func resourceAwsApiGatewayStageUpdate(d *schema.ResourceData, meta interface{}) | |||
| conn := meta.(*AWSClient).apigateway | |||
|
|
|||
| d.Partial(true) | |||
|
|
|||
| stageArn := arnString( | |||
There was a problem hiding this comment.
FYI this function was removed in #4053 in preference of building these via the SDK arn package directly -- fixing during merge 😃
|
This has been released in version 1.16.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
#2828