resource/aws_sns_topic: Add support for delivery status #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Acceptance tests: |
Ninir
added
the
enhancement
gazoakley
changed the title
gazoakley
changed the title
|
@radeksimko Any chance someone can review this? The previous iteration was planned for review by @catsby: hashicorp/terraform#14101 (comment) |
bflad
approved these changes
Feb 6, 2018
There was a problem hiding this comment.
@gazoakley thanks again for porting this over -- I confirmed it works when merged with the latest acceptance testing. 🚀
make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopic_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSNSTopic_ -timeout 120m
=== RUN TestAccAWSSNSTopic_importBasic
--- PASS: TestAccAWSSNSTopic_importBasic (11.55s)
=== RUN TestAccAWSSNSTopic_basic
--- PASS: TestAccAWSSNSTopic_basic (9.43s)
=== RUN TestAccAWSSNSTopic_name
--- PASS: TestAccAWSSNSTopic_name (10.53s)
=== RUN TestAccAWSSNSTopic_namePrefix
--- PASS: TestAccAWSSNSTopic_namePrefix (9.36s)
=== RUN TestAccAWSSNSTopic_policy
--- PASS: TestAccAWSSNSTopic_policy (9.53s)
=== RUN TestAccAWSSNSTopic_withIAMRole
--- PASS: TestAccAWSSNSTopic_withIAMRole (30.27s)
=== RUN TestAccAWSSNSTopic_withFakeIAMRole
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (66.89s)
=== RUN TestAccAWSSNSTopic_withDeliveryPolicy
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (10.19s)
=== RUN TestAccAWSSNSTopic_deliveryStatus
--- PASS: TestAccAWSSNSTopic_deliveryStatus (10.23s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 168.040s
aws/resource_aws_sns_topic.go
Outdated
| @@ -63,6 +74,58 @@ func resourceAwsSnsTopic() *schema.Resource { | |||
| return json | |||
| }, | |||
| }, | |||
| "application_success_feedback_role_arn": &schema.Schema{ | |||
There was a problem hiding this comment.
Nitpick: The &schema.Schema are no longer required as of Go 1.7 and likely copied from other attributes that we haven't yet cleaned up. I will fix these on merge.
… from new delivery status attributes
|
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported hashicorp/terraform#14101 from to address #515