Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NodeJS v8.10.0 runtime in Lambda functions #4019 #4020

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

tommywo
Copy link
Contributor

@tommywo tommywo commented Apr 3, 2018

No description provided.

@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Apr 3, 2018
@bflad
Copy link
Contributor

bflad commented Apr 3, 2018

Interesting that this has been updated in the Lambda Developer Guide but not upstream in the AWS SDK. I created an upstream SDK ticket for reference: aws/aws-sdk-go#1879

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. labels Apr 3, 2018
@bflad bflad added this to the v1.14.0 milestone Apr 3, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this patch by locally updating the basic test to use runtime nodejs8.10 and it was successful:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSLambdaFunction_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSLambdaFunction_basic -timeout 120m
=== RUN   TestAccAWSLambdaFunction_basic
--- PASS: TestAccAWSLambdaFunction_basic (37.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.870s

Merging since we don't know how long it will take the upstream SDK to be properly updated. 👍

@bflad bflad merged commit 0ce0962 into hashicorp:master Apr 3, 2018
bflad added a commit that referenced this pull request Apr 3, 2018
@bflad
Copy link
Contributor

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/lambda Issues and PRs that pertain to the lambda service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants