Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_wafregional_rule: Validate all predicate types #4046

Merged
merged 1 commit into from
Apr 4, 2018
Merged

resource/aws_wafregional_rule: Validate all predicate types #4046

merged 1 commit into from
Apr 4, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Apr 4, 2018

Closes #4039

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. labels Apr 4, 2018
@bflad bflad requested review from radeksimko and appilon April 4, 2018 18:58
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Apr 4, 2018
@bflad bflad mentioned this pull request Apr 4, 2018
Closed
@bflad bflad added this to the v1.14.0 milestone Apr 4, 2018
@bflad bflad merged commit de34a4e into master Apr 4, 2018
@bflad bflad deleted the f-aws_wafregional_rule-support-all-types branch April 4, 2018 19:49
bflad added a commit that referenced this pull request Apr 4, 2018
@bflad
Update CHANGELOG for #4046
bd52d62
@bflad bflad mentioned this pull request Apr 5, 2018
Closed
@bflad
Copy link
Contributor Author

bflad commented Apr 6, 2018

This has been released in version 1.14.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

@radeksimko radeksimko Awaiting requested review from radeksimko

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/waf Issues and PRs that pertain to the waf service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging this pull request may close these issues.

aws_wafregional_geo_match_set cannot be added to a rule
2 participants
@bflad @appilon