Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_eks_cluster: allow referencing arn attribute #4767

Closed
wants to merge 1 commit into from

Conversation

razaj92
Copy link
Contributor

@razaj92 razaj92 commented Jun 6, 2018

Fixes #4764

Changes proposed in this pull request:

  • expose arn in resource aws_eks_cluster
  • expose arn in data aws_eks_cluster

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEksCluster_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -run=TestAccAWSEksCluster_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSEksCluster_basic
--- PASS: TestAccAWSEksCluster_basic (785.40s)
PASS
ok  	github.com/terraform-providers/terraform-prov
...

@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 6, 2018
@razaj92 razaj92 force-pushed the aws_eks_cluster_arn branch from 8a6cd32 to 90f2878 Compare June 6, 2018 16:02
@ghost ghost added the size/S Managed by automation to categorize the size of a PR. label Jun 6, 2018
@bflad
Copy link
Contributor

bflad commented Jun 6, 2018

Thanks for submitting this @razaj92! Unfortunately we submitted around the same time and the fix from #4766 landed first. 😅 Good news is that this will be fixed in version 1.23.0 of the AWS provider.

@bflad bflad closed this Jun 6, 2018
bflad added a commit that referenced this pull request Jun 6, 2018
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_eks_cluster not exporting arn attribute as per docs
2 participants