Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_glue_catalog_database: Prevent error when deleted outside Terraform #5141

Merged
merged 1 commit into from
Jul 11, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jul 10, 2018

Fixes #5136

Changes proposed in this pull request:

  • Ignore EntityNotFoundException in exists function for aws_glue_catalog_database resource

Previously:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogDatabase_recreates'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCatalogDatabase_recreates -timeout 120m
=== RUN   TestAccAWSGlueCatalogDatabase_recreates
--- FAIL: TestAccAWSGlueCatalogDatabase_recreates (10.99s)
	testing.go:518: Step 1 error: Error refreshing: 1 error(s) occurred:

		* aws_glue_catalog_database.test: 1 error(s) occurred:

		* aws_glue_catalog_database.test: aws_glue_catalog_database.test: EntityNotFoundException: Database my_test_catalog_database_6550552809316099925 not found.
			status code: 400, request id: 4080a81b-8455-11e8-8ae0-d76c07653239
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	11.031s
make: *** [testacc] Error 1

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogDatabase'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSGlueCatalogDatabase -timeout 120m
=== RUN   TestAccAWSGlueCatalogDatabase_importBasic
--- PASS: TestAccAWSGlueCatalogDatabase_importBasic (14.76s)
=== RUN   TestAccAWSGlueCatalogDatabase_full
--- PASS: TestAccAWSGlueCatalogDatabase_full (27.74s)
=== RUN   TestAccAWSGlueCatalogDatabase_recreates
--- PASS: TestAccAWSGlueCatalogDatabase_recreates (12.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	55.008s

@bflad bflad added bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. labels Jul 10, 2018
@bflad bflad requested a review from a team July 10, 2018 15:31
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jul 10, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@bflad bflad added this to the v1.27.0 milestone Jul 11, 2018
@bflad bflad merged commit f9cd8c7 into master Jul 11, 2018
@bflad bflad deleted the b-aws_glue_catalog_database-notfound branch July 11, 2018 16:46
bflad added a commit that referenced this pull request Jul 11, 2018
@bflad
Copy link
Contributor Author

bflad commented Jul 11, 2018

This has been released in version 1.27.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EntityNotFoundException when aws_glue_catalog_database is missing
2 participants