Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_api_gateway_model: Support resource import #5572

Merged
merged 1 commit into from
Aug 20, 2018
Merged

resource/aws_api_gateway_model: Support resource import #5572

merged 1 commit into from
Aug 20, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Aug 16, 2018

Reference: #558

Changes proposed in this pull request:

  • Support, test, and document resource import

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayModel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayModel_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayModel_basic
--- PASS: TestAccAWSAPIGatewayModel_basic (14.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.981s

@bflad
resource/aws_api_gateway_model: Support resource import
3459a1e 
* Support, test, and document resource import

make testacc TEST=./aws TESTARGS='-run=TestAccAWSAPIGatewayModel_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAPIGatewayModel_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayModel_basic
--- PASS: TestAccAWSAPIGatewayModel_basic (14.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.981s
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. labels Aug 16, 2018
@bflad bflad requested a review from a team August 16, 2018 04:43
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Aug 16, 2018
@bflad bflad mentioned this pull request Aug 16, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor 🤔 but otherwise LGTM 👍

aws/resource_aws_api_gateway_model.go
return nil, err
}

d.SetId(aws.StringValue(output.Id))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not call d.SetId and then the Read function? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the model ID is actually worthless for read. At some point we should switch the resource ID to be the REST API ID and model name instead of the model ID, but that could be perceived as a breaking change.

@bflad bflad added this to the v1.33.0 milestone Aug 20, 2018
@bflad bflad merged commit 2a2f1af into master Aug 20, 2018
@bflad bflad deleted the f-aws_api_gateway_model-import branch August 20, 2018 15:05
bflad added a commit that referenced this pull request Aug 20, 2018
@bflad
Update CHANGELOG for #5572
e788c97
@bflad
Copy link
Contributor Author

bflad commented Aug 22, 2018

This has been released in version 1.33.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/apigateway Issues and PRs that pertain to the apigateway service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff