resource/aws_iam_policy: Ensure description is properly read during creation #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reation
This resource was previously not following best practices of calling the read function after creation. Now it will read back information from the API, which tangentally fixes the description not being available in the CreatePolicy response.
Changes:
* Create separate acceptance tests for all arguments
* Call read function after create and update functions
* Create `testAccCheckResourceAttrGlobalARN` for checking global ARN attributes
* Remove extraneous aws/import_aws_iam_policy_test.go
Previously (before code updates):
```
=== RUN TestAccAWSIAMPolicy_basic
--- PASS: TestAccAWSIAMPolicy_basic (10.15s)
=== RUN TestAccAWSIAMPolicy_description
--- FAIL: TestAccAWSIAMPolicy_description (5.06s)
testing.go:527: Step 0 error: Check failed: Check 2/2 error: aws_iam_policy.test: Attribute 'description' expected "description1", got ""
=== RUN TestAccAWSIAMPolicy_namePrefix
--- PASS: TestAccAWSIAMPolicy_namePrefix (9.72s)
=== RUN TestAccAWSIAMPolicy_path
--- PASS: TestAccAWSIAMPolicy_path (9.85s)
=== RUN TestAccAWSIAMPolicy_policy
--- PASS: TestAccAWSIAMPolicy_policy (13.49s)
```
Now:
```
=== RUN TestAccAWSIAMPolicy_basic
--- PASS: TestAccAWSIAMPolicy_basic (10.29s)
=== RUN TestAccAWSIAMPolicy_description
--- PASS: TestAccAWSIAMPolicy_description (8.00s)
=== RUN TestAccAWSIAMPolicy_namePrefix
--- PASS: TestAccAWSIAMPolicy_namePrefix (9.15s)
=== RUN TestAccAWSIAMPolicy_path
--- PASS: TestAccAWSIAMPolicy_path (9.25s)
=== RUN TestAccAWSIAMPolicy_policy
--- PASS: TestAccAWSIAMPolicy_policy (15.21s)
```
bflad
added
bug
|
This has been released in version 1.37.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via acceptance testing after merging #5815
This resource was previously not following best practices of calling the read function after creation. Now it will read back information from the API, which tangentially fixes the description not being available in the
CreatePolicyresponse and the resource always callingd.Set("description", "").Changes:
TestAccAWSIAMPolicy_)testAccCheckResourceAttrGlobalARNfor checking global ARN attributesPreviously (before code updates):
Now: