Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_appsync_graphql_api: Various enhancements and properly handle updates #6138

Merged
merged 1 commit into from
Oct 18, 2018
Merged

resource/aws_appsync_graphql_api: Various enhancements and properly handle updates #6138

merged 1 commit into from
Oct 18, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 12, 2018 •
edited
Loading

Closes #3974
Closes #4879
Closes #5937
Closes #6134

Changes proposed in this pull request:

  • Support logging configuration
  • Support OPENID_CONNECT authentication
  • Make Cognito User Pool AWS Region configuration optional
  • Add uris attribute
  • Properly handle updates by passing all parameters

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppsyncGraphqlApi_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAppsyncGraphqlApi_ -timeout 120m
=== RUN   TestAccAWSAppsyncGraphqlApi_basic
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (10.12s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (14.83s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (11.27s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (8.65s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (13.12s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (9.29s)
=== RUN   TestAccAWSAppsyncGraphqlApi_LogConfig
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (11.77s)
=== RUN   TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (23.29s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (21.16s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (16.24s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (16.75s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (15.49s)
=== RUN   TestAccAWSAppsyncGraphqlApi_Name
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (15.78s)
=== RUN   TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (22.30s)
=== RUN   TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (18.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	231.295s

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. labels Oct 12, 2018
@bflad bflad requested a review from a team October 12, 2018 16:43
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 12, 2018
This was referenced Oct 12, 2018
Closed
Closed
Closed
@bflad bflad force-pushed the f-aws_appsync_graphql_api-openid_connect branch from 250747f to 5091bd1 Compare October 12, 2018 19:00
This was referenced Oct 12, 2018
Closed
Closed
@bflad
resource/aws_appsync_graphql_api: Various enhancements and properly h…
233fd58 
…andle updates

* Support logging configuration
* Support `OPENID_CONNECT` authentication
* Make Cognito User Pool AWS Region configuration optional
* Add `uris` attribute
* Properly handle updates by passing all parameters

```
$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppsyncGraphqlApi_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSAppsyncGraphqlApi_ -timeout 120m
=== RUN   TestAccAWSAppsyncGraphqlApi_basic
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (10.12s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (14.83s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (11.27s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (8.65s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (13.12s)
=== RUN   TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (9.29s)
=== RUN   TestAccAWSAppsyncGraphqlApi_LogConfig
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (11.77s)
=== RUN   TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (23.29s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (21.16s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (16.24s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (16.75s)
=== RUN   TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (15.49s)
=== RUN   TestAccAWSAppsyncGraphqlApi_Name
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (15.78s)
=== RUN   TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (22.30s)
=== RUN   TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (18.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	231.295s
```
@bflad bflad force-pushed the f-aws_appsync_graphql_api-openid_connect branch from 5091bd1 to 233fd58 Compare October 18, 2018 13:04
@bflad
Copy link
Contributor Author

bflad commented Oct 18, 2018

Rebased against master and verified all acceptance testing passes still. Merging!

--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AWSIAM (10.50s)
--- PASS: TestAccAWSAppsyncGraphqlApi_basic (10.53s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_OpenIDConnect (10.78s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig (12.21s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_AmazonCognitoUserPools (13.08s)
--- PASS: TestAccAWSAppsyncGraphqlApi_Name (15.26s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_Issuer (16.01s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType (16.08s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_IatTTL (16.31s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_AuthTTL (16.97s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_AwsRegion (18.15s)
--- PASS: TestAccAWSAppsyncGraphqlApi_UserPoolConfig_DefaultAction (19.95s)
--- PASS: TestAccAWSAppsyncGraphqlApi_LogConfig_FieldLogLevel (24.10s)
--- PASS: TestAccAWSAppsyncGraphqlApi_AuthenticationType_APIKey (41.93s)
--- PASS: TestAccAWSAppsyncGraphqlApi_OpenIDConnectConfig_ClientID (47.90s)

@bflad bflad added this to the v1.41.0 milestone Oct 18, 2018
@bflad bflad merged commit 44f0e23 into master Oct 18, 2018
@bflad bflad deleted the f-aws_appsync_graphql_api-openid_connect branch October 18, 2018 13:21
bflad added a commit that referenced this pull request Oct 18, 2018
@bflad
Update CHANGELOG for #6138
84453cd
@bflad
Copy link
Contributor Author

bflad commented Oct 18, 2018

This has been released in version 1.41.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/appsync Issues and PRs that pertain to the appsync service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.41.0
2 participants
@bflad @paddycarver