Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_network_acl: Properly handle ICMP code and type with IPv6 ICMP (protocol 58) #6264

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 25, 2018

Fixes #6262

Changes proposed in this pull request:

  • Allow protocol 58 to propagate ICMP code and type configuration

Previously:

--- FAIL: TestAccAWSNetworkAcl_ipv6ICMPRules (12.17s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_network_acl.test: 1 error occurred:
        	* aws_network_acl.test: Error creating ingress entry: MissingParameter: The request must contain the parameter icmpTypeCode.type
        	status code: 400, request id: 9551aec6-d3cf-435f-a35d-0d60b8fd2a69

Output from acceptance testing:

--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (17.51s)

…6 ICMP (protocol 58)

Previously:

```
--- FAIL: TestAccAWSNetworkAcl_ipv6ICMPRules (12.17s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_network_acl.test: 1 error occurred:
        	* aws_network_acl.test: Error creating ingress entry: MissingParameter: The request must contain the parameter icmpTypeCode.type
        	status code: 400, request id: 9551aec6-d3cf-435f-a35d-0d60b8fd2a69
```

Output from acceptance testing:

```
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (17.51s)
```
@bflad bflad added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Oct 25, 2018
@ghost ghost added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 25, 2018
@bflad bflad requested a review from a team October 25, 2018 17:59
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor 🤔 but this otherwise LGTM 👍

@@ -43,7 +43,7 @@ func expandNetworkAclEntries(configured []interface{}, entryType string) ([]*ec2
}

// Specify additional required fields for ICMP
if p == 1 {
if p == 1 || p == 58 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this wants a comment/constant explaining what 1 and 58 represent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a technical debt issue for this: #6302

@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
@bflad bflad merged commit 0d481bc into master Oct 30, 2018
@bflad bflad deleted the b-aws_network_acl-58 branch October 30, 2018 13:29
bflad added a commit that referenced this pull request Oct 30, 2018
@bflad
Copy link
Contributor Author

bflad commented Nov 1, 2018

This has been released in version 1.42.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Network ACL Error when creating IPv6 ICMP rule
2 participants