Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add import aws iam group policy attachment #6625

Merged
merged 2 commits into from
Dec 2, 2018
Merged

Feature/add import aws iam group policy attachment #6625

merged 2 commits into from
Dec 2, 2018

Conversation

teraken0509
Copy link
Contributor

Fixed #6602

Changes proposed in this pull request:

  • Add import aws_iam_group_policy_attachment without changing create behavior.
  • Update Document

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMGroupPolicyAttachment_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSIAMGroupPolicyAttachment_basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSIAMGroupPolicyAttachment_basic
=== PAUSE TestAccAWSIAMGroupPolicyAttachment_basic
=== CONT  TestAccAWSIAMGroupPolicyAttachment_basic
--- PASS: TestAccAWSIAMGroupPolicyAttachment_basic (59.71s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	59.769s

@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 2, 2018
@bflad bflad added this to the v1.51.0 milestone Dec 2, 2018
bflad
bflad approved these changes Dec 2, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor documentation fix, thanks @kterada0509! 🚀

--- PASS: TestAccAWSIAMGroupPolicyAttachment_basic (16.31s)

aws/resource_aws_iam_group_policy_attachment_test.go
ResourceName: "aws_iam_group_policy_attachment.test-attach",
ImportState: true,
ImportStateIdFunc: testAccAWSIAMGroupPolicyAttachmentImportStateIdFunc("aws_iam_group_policy_attachment.test-attach"),
// We do not have a way to align IDs since the Create function uses resource.PrefixedUniqueId()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this comment. 😄

website/docs/r/iam_group_policy_attachment.markdown
@@ -37,3 +37,9 @@ The following arguments are supported:

* `group` (Required) - The group the policy should be applied to
* `policy_arn` (Required) - The ARN of the policy you want to apply

## Import
IAM group policy attachments can be imported using the group name and policy arn separated by `/`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's an additional space in front of this line and the next. Will fix on merge. 👍

@bflad bflad merged commit 59909e7 into hashicorp:master Dec 2, 2018
bflad added a commit that referenced this pull request Dec 2, 2018
@bflad
Update CHANGELOG for #6625
5c3b0a4
@bflad
Copy link
Contributor

bflad commented Dec 5, 2018

This has been released in version 1.51.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@teraken0509 teraken0509 deleted the feature/add-import-aws_iam_group_policy_attachment branch March 5, 2020 14:01
@ghost
Copy link

ghost commented Mar 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.51.0
Development

Successfully merging this pull request may close these issues.

Add import functionality to iam_group_policy_attachment and iam_user_policy_attachment
2 participants
@teraken0509 @bflad